DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C98920652
Subject: Re: [PATCH] cfg80211: fix wext-compat memory leak
To:     Johannes Berg <johannes@sipsolutions.net>,
        linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Cc:     Stefan Seyfried <seife+kernel@b1-systems.com>
References: <20180930105300.30797-1-stefan.seyfried@googlemail.com>
 <1538377946.3126.0.camel@sipsolutions.net>
From:   Stefan Seyfried <stefan.seyfried@googlemail.com>
Openpgp: preference=signencrypt
Message-ID: <e7bb48f5-3933-6d0b-160f-8d0801e3c1a7@message-id.googlemail.com>
Date:   Mon, 1 Oct 2018 10:55:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <1538377946.3126.0.camel@sipsolutions.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Johannes,

Am 01.10.18 um 09:12 schrieb Johannes Berg:
> Hi Stefan,
> 
> Thanks for the investigation & fix. I've changed the fix to use
> cfg80211_sinfo_release_content(),

Being totally unfamiliar with the code, I was not sure about that :-)

> take care of the error path in
> cfg80211_wext_giwrate() and added a Fixes tag :-)

That's certainly much better.

Thanks!

(kudos to Vlastimil Babka who pointed out trace-cmd to me on the
 opensuse-kernel malinglist, which made the investigation quite easy)
-- 
Stefan Seyfried

"For a successful technology, reality must take precedence over
 public relations, for nature cannot be fooled." -- Richard Feynman