DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83DA320652
Date:   Mon, 1 Oct 2018 14:29:29 +0530
From:   Ajay Singh <ajay.kathat@microchip.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
CC:     <linux-wireless@vger.kernel.org>, <devel@driverdev.osuosl.org>,
        <venkateswara.kaja@microchip.com>, <gregkh@linuxfoundation.org>,
        <ganesh.krishna@microchip.com>, <adham.abozaeid@microchip.com>,
        <aditya.shankar@microchip.com>
Subject: Re: [PATCH v3 00/29] staging: wilc1000: avoid static variables and
 cleanup changes
Message-ID: <20181001142929.7fc422d0@ajaysk-VirtualBox>
In-Reply-To: <20181001074734.w766omhed4ri3zuy@mwanda>
References: <1537856624-22157-1-git-send-email-ajay.kathat@microchip.com>
        <20181001074734.w766omhed4ri3zuy@mwanda>
Organization: Microchip Technology
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Dan,

On Mon, 1 Oct 2018 10:47:34 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> On Tue, Sep 25, 2018 at 11:53:15AM +0530, Ajay Singh wrote:
> > This patch series contains changes to avoid the use of static
> > variables. Cleanup changes to fix some checkpatch issues and return
> > void for function if their return value is not used.
> > Also deleted 'wilc_debugfs.c' file as it's not used.
> > 
> > Changes since v2:
> >    Included Joe's suggestion for patch#28
> >     - replaced previous patch with an improved version(refactor
> > code)
> > 
> > Changes since v1:
> >    Address Dan's comment for patch#29
> >     - return the correct error for failure in the second iteration  
> 
> Btw, I hate re-reviewing patches and I know everyone hates sending
> them. If someone complains about a 28/29 or a 29/29, then you can
> just ask Greg to apply the first 27 and redo the others in a follow
> on patchset.
> 
Sure, I will keep this point in mind while sending the series updates.

Regards
Ajay