DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9015F2084C
Message-ID: <1538388776.3126.24.camel@sipsolutions.net>
Subject: Re: [PATCH v5 1/3] cfg80211: support FTM responder
 configuration/statistics
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
        ath10k@lists.infradead.org
Cc:     linux-wireless@vger.kernel.org,
        David Spinadel <david.spinadel@intel.com>
Date:   Mon, 01 Oct 2018 12:12:56 +0200
In-Reply-To: <1537489811-5752-2-git-send-email-pradeepc@codeaurora.org>
References: <1537489811-5752-1-git-send-email-pradeepc@codeaurora.org>
         <1537489811-5752-2-git-send-email-pradeepc@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, 2018-09-20 at 17:30 -0700, Pradeep Kumar Chitrapu wrote:
> Allow userspace to enable fine timing measurement responder
> functionality with configurable lci/civic parameters in AP mode.
> This can be done at AP start or changing beacon parameters.
> 
> A new EXT_FEATURE flag is introduced for drivers to advertise
> the capability.
> 
> Also nl80211 API support for retrieving statistics is added.

I applied this, but with some changes. Notably,

>  /**
> + * cfg80211_ftm_responder_params - FTM responder parameters

I removed this struct, since it's no longer needed.

You do use it in mac80211, but since cfg80211 doesn't use it you should
declare it as ieee80211_ftm_respodner_params and use it in mac80211
only, I think.

johannes