DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EE732089A
Message-ID: <1538389142.3126.29.camel@sipsolutions.net>
Subject: Re: [PATCH] nl80211: Add per peer statistics to compute FCS error
 rate
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jouni Malinen <jouni@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org,
        Ankita Bajaj <bankita@codeaurora.org>
Date:   Mon, 01 Oct 2018 12:19:02 +0200
In-Reply-To: <1538060517-32208-1-git-send-email-jouni@codeaurora.org>
References: <1538060517-32208-1-git-send-email-jouni@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, 2018-09-27 at 18:01 +0300, Jouni Malinen wrote:
> From: Ankita Bajaj <bankita@codeaurora.org>
> 
> Add support for drivers to report the total number of MPDUs received
> and the number of MPDUs received with an FCS error from a specific
> peer. These counters will be incremented only when the TA of the
> frame matches the MAC address of the peer irrespective of FCS
> error.

Hmm. The error one seems mostly reasonable, I guess, but do we really
not having anything that's the total number of MPDUs already?

And then, I guess, what exactly would you want there? We might not
always even be able to provide that?

I'm also left wondering what the application here is - perhaps another
thing we could just implement in BPF with the hooks I previously posted
(but admittedly never finished)?

johannes