DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E8612064A
MIME-Version: 1.0
References: <20180925081933.28553-1-enrique.giraldo@galgus.net> <1537954007.28767.10.camel@sipsolutions.net>
In-Reply-To: <1537954007.28767.10.camel@sipsolutions.net>
From:   Enrique Giraldo <hgiraldos@gmail.com>
Date:   Mon, 1 Oct 2018 12:44:19 +0200
Message-ID: <CAEbaMQKC4nCL=aZWdf7xSFcO1wJ0qP6scnW7a4gg5M3AEx1qYQ@mail.gmail.com>
Subject: Re: [PATCH] New functionality for aborting ongoing CAC.
To:     johannes@sipsolutions.net
Cc:     linux-wireless@vger.kernel.org,
        Enrique Giraldo <enrique.giraldo@galgus.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

You are right, it is possible to do it as you comment
(NL80211_CMD_STOP_AP and then NL80211_CMD_START_AP). It is therefore
not necessary a specific command to abort the CAC.
Thank you very much for the clarification and the time spent.

PS: If you use OpenWRT you have to control the STOP and the START, the
command "wifi" does not work properly.
El mi=C3=A9., 26 sept. 2018 a las 11:26, Johannes Berg
(<johannes@sipsolutions.net>) escribi=C3=B3:
>
> On Tue, 2018-09-25 at 10:19 +0200, Enrique Giraldo wrote:
> > Add NL80211_CMD_ABORT_CAC to the nl80211 interface.
>
> As Arend pointed out, this really needs a much better commit message.
>
> Please also adjust the subject to have a proper prefix etc. See
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa=
tches
> for some help with that.
>
> > @@ -3227,6 +3228,7 @@ struct cfg80211_ops {
> >       int     (*scan)(struct wiphy *wiphy,
> >                       struct cfg80211_scan_request *request);
> >       void    (*abort_scan)(struct wiphy *wiphy, struct wireless_dev *w=
dev);
> > +     void    (*abort_cac)(struct wiphy *wiphy, struct wireless_dev *wd=
ev);
>
> This is fine, you can add in the middle of the struct.
>
> >
> > @@ -1220,6 +1223,7 @@ enum nl80211_commands {
> >       NL80211_CMD_WIPHY_REG_CHANGE,
> >
> >       NL80211_CMD_ABORT_SCAN,
> > +     NL80211_CMD_ABORT_CAC,
> >
> >       NL80211_CMD_START_NAN,
>
> This is *not* OK, as the comments here indicate, we must never add
> anything in the middle of this enum, doing so breaks userspace ABI.
>
> johannes