Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29755C43143 for ; Mon, 1 Oct 2018 13:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E167D2084C for ; Mon, 1 Oct 2018 13:33:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="XJgfIYfk"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="GidZEheF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E167D2084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729368AbeJAUKw (ORCPT ); Mon, 1 Oct 2018 16:10:52 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:32814 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729182AbeJAUKv (ORCPT ); Mon, 1 Oct 2018 16:10:51 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 4DD4860A98; Mon, 1 Oct 2018 13:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538400781; bh=f4FmbReDEZ1GO3wIZ6UOJ/tbhv3KtXrwn3V1uu7dHw4=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=XJgfIYfkevUC3So4JTVx71eVS3Xe9NjT0SFaqMrdnFLbiwQS5aJ2VuC5Lsy18K/08 8+gs8yK+JHNxSunIoQyqrOFk4nwcenmmYwp+yD7JGPY6I6jpWqXPesp1EeIIZEgeJY drVYraSOlTEgrft9iLXZzeejq9mDrm6FAM2f41t4= Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D771E6079B; Mon, 1 Oct 2018 13:32:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538400780; bh=f4FmbReDEZ1GO3wIZ6UOJ/tbhv3KtXrwn3V1uu7dHw4=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=GidZEheF4JGkwTc60R4HiEGKkUqLat9amj8iacrNBX3zk6mJ0zFYgXLqY35NmKnJt LenjRajWwO9+EzOD2uxz7ZD5ckChwOjxWQ48c9hGfwJZmY7oeJ207D9wTRixwz1ILX Pq2hzpHstHJ473UdQGnw/TWnh5AUv+xSgyCT2QCc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D771E6079B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath10k: fix vdev-start timeout on error From: Kalle Valo In-Reply-To: <1531512596-31355-1-git-send-email-greearb@candelatech.com> References: <1531512596-31355-1-git-send-email-greearb@candelatech.com> To: greearb@candelatech.com Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, Ben Greear User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20181001133301.4DD4860A98@smtp.codeaurora.org> Date: Mon, 1 Oct 2018 13:33:01 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org greearb@candelatech.com wrote: > The vdev-start-response message should cause the > completion to fire, even in the error case. Otherwise, > the user still gets no useful information and everything > is blocked until the timeout period. > > Add some warning text to print out the invalid status > code to aid debugging, and propagate failure code. > > Signed-off-by: Ben Greear > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 833fd34d743c ath10k: fix vdev-start timeout on error -- https://patchwork.kernel.org/patch/10524087/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches