DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 327952084D
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 04 Oct 2018 23:02:20 +0530
From:   bankita@codeaurora.org
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Jouni Malinen <jouni@codeaurora.org>,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Add per peer statistics to compute FCS error
 rate
In-Reply-To: <1538389142.3126.29.camel@sipsolutions.net>
References: <1538060517-32208-1-git-send-email-jouni@codeaurora.org>
 <1538389142.3126.29.camel@sipsolutions.net>
Message-ID: <a4d0af139d550a248ecd280798bbdd2a@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2018-10-01 15:49, Johannes Berg wrote:
> On Thu, 2018-09-27 at 18:01 +0300, Jouni Malinen wrote:
>> From: Ankita Bajaj <bankita@codeaurora.org>
>> 
>> Add support for drivers to report the total number of MPDUs received
>> and the number of MPDUs received with an FCS error from a specific
>> peer. These counters will be incremented only when the TA of the
>> frame matches the MAC address of the peer irrespective of FCS
>> error.

We do have rx_packets field but it is for MMPDUs and MSDUs which might 
not reflect the number of MPDUs in all cases. Hence we introduced new 
field for MPDU count.

> Hmm. The error one seems mostly reasonable, I guess, but do we really
> not having anything that's the total number of MPDUs already?
> 
> And then, I guess, what exactly would you want there? We might not
> always even be able to provide that?

> I'm also left wondering what the application here is -

These two fields together will help to find bad rx link with a specific 
peer. This information can be used for example to steer the client to a 
different BSS.

Ankita