DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72FBE2084D
Date:   Fri, 5 Oct 2018 08:03:00 +0530
From:   Ajay Singh <ajay.kathat@microchip.com>
To:     Kalle Valo <kvalo@codeaurora.org>
CC:     Arend van Spriel <arend.vanspriel@broadcom.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "Nicolas Ferre - M43238" <Nicolas.Ferre@microchip.com>,
        Ganesh Krishna - C00112 <Ganesh.Krishna@microchip.com>,
        Adham Abozaeid - C43058 <Adham.Abozaeid@microchip.com>,
        Aditya Shankar - I16078 <Aditya.Shankar@microchip.com>
Subject: Re: feedback on mainlining wilc1000 staging driver
Message-ID: <20181005080300.5030f616@ajaysk-VirtualBox>
In-Reply-To: <871s953nhu.fsf@codeaurora.org>
References: <20180816015243.545cd009@ajaysk-VirtualBox>
        <87sh3etwoj.fsf@purkki.adurom.net>
        <87o9e2twe9.fsf@purkki.adurom.net>
        <20180817100233.7f1c00d9@ajaysk-VirtualBox>
        <8736vdv3f5.fsf@kamboji.qca.qualcomm.com>
        <5B768574.6060009@broadcom.com>
        <87y3d5tmod.fsf@kamboji.qca.qualcomm.com>
        <20180817143911.5f0ee545@ajaysk-VirtualBox>
        <87r2ipnxxa.fsf@kamboji.qca.qualcomm.com>
        <20180926155743.032caa37@ajaysk-VirtualBox>
        <871s953nhu.fsf@codeaurora.org>
Organization: Microchip Technology
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Kalle,

On Thu, 4 Oct 2018 15:27:57 +0300
Kalle Valo <kvalo@codeaurora.org> wrote:

> Ajay Singh <ajay.kathat@microchip.com> writes:
> 
> > Hi Kalle,
> >
> > On Thu, 23 Aug 2018 16:37:45 +0530
> > Kalle Valo <kvalo@codeaurora.org> wrote:
> >
> >> Ajay Singh <ajay.kathat@microchip.com> writes:
> >> 
> >> >> >>> We need help to review and identify if there are any pending
> >> >> >>> items for wilc1000 driver, so we can address those issues
> >> >> >>> and make it ready to move to the wireless subsystem.    
> >> >> >>
> >> >> >> I think the best way to get that forward is to submit a patch
> >> >> >> (or patchset) to linux-wireless, that's the easiest for
> >> >> >> reviewers.    
> >> >> >
> >> >> > For brcm80211 drivers we used a single patch introducing it
> >> >> > under the wireless drivers folder. Because it was quite a
> >> >> > sizable patch we parked it on the wireless wiki page. Had a
> >> >> > few iterations doing it like that.    
> >> >> 
> >> >> Another option is to split it so that there's one patch per
> >> >> file, should be even pretty easy to automate that. It's just so
> >> >> much easier to comment on a patch submitted by email compared
> >> >> to the reviewer manually copying code and then commenting it,
> >> >> yuck. 
> >> >
> >> > Sure. I will prepare a patch per file send for review as its
> >> > easy to review.
> >> >
> >> > As Greg suggested, I will wait for the merge window to close and
> >> > after completing pending patches to staging, I will start the
> >> > review.
> >> >
> >> > For my understanding, the patches for review will be based on
> >> > wireless-testing branch.  
> >> 
> >> In this case I think wireless-drivers-next is the safest choise,
> >> wireless-testing also has other trees which might cause conflicts
> >> etc.
> >
> > I have submitted a patch series for wilc1000 driver, single file
> > per patch and its based on wireless-drivers-next. 
> > I hope its done correctly, please provide inputs so we can
> > address and make this driver ready for mainline.
> 
> Thanks, I see it in patchwork:
> 
> https://patchwork.kernel.org/project/linux-wireless/list/?series=23251&state=*&order=date
> 
> Do note that we have also another new driver (rtwlan/rtw88) under
> review so review from the wireless folks might take some time.
> 

Thanks for the update.
Btw I could see our driver was added to the pending branch. Just
curious, could you please share details about how the pending branch is
used ?

Regards,
Ajay