DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E541A20875
MIME-Version: 1.0
References: <20181005083748.GD1931@redhat.com>
In-Reply-To: <20181005083748.GD1931@redhat.com>
From:   Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Date:   Fri, 5 Oct 2018 10:43:10 +0200
Message-ID: <CAA2SeNLtnOFJpriEVtMiM3c3v-Hb20mayZ2+WSeY76Bvcd_-GQ@mail.gmail.com>
Subject: Re: crash in ieee80211_wake_txqs
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     mpubbise@codeaurora.org, Johannes Berg <johannes@sipsolutions.net>,
        linux-wireless <linux-wireless@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

>
> Hi
>
> I have crash in ieee80211_wake_txqs:
> https://imgur.com/a/VIrU9yK
> when starting mt76x0u driver. Not sure if this is beacuse the driver
> do not initalize sta->txq properly, but reverting the
>
> commit 21a5d4c3a45ca608477a083096cfbce76e449a0c
> Author: Manikanta Pubbisetty <mpubbise@codeaurora.org>
> Date:   Wed Jul 11 00:12:53 2018 +0530
>
>     mac80211: add stop/start logic for software TXQs
>
> make crash gone.
>
> gdb pointed at 'if (ac != txq->ac)' line in the code:
>
>                for (i = 0; i < ARRAY_SIZE(sta->sta.txq); i++) {
>                        struct ieee80211_txq *txq = sta->sta.txq[i];
>
>                        txqi = to_txq_info(txq);
>
>                        if (ac != txq->ac)
>                                continue;
>
> Looks txq is NULL and referencing txq->ac crashes.
>
> Thanks
> Stanislaw

Hi Stanislaw,

I guess it is fixed here:
https://marc.info/?l=linux-kernel&m=153694084922438&w=2

Regrads,
Lorenzo

-- 
UNIX is Sexy: who | grep -i blonde | talk; cd ~; wine; talk; touch;
unzip; touch; strip; gasp; finger; gasp; mount; fsck; more; yes; gasp;
umount; make clean; sleep