DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F330C2147D
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E1662605FF
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Tony Chuang <yhchuang@realtek.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>
Subject: Re: [PATCH 01/12] rtwlan: main files
References: <1537509847-21087-2-git-send-email-yhchuang@realtek.com>
        <20180927135040.GA4712@redhat.com>
        <F7CD281DE3E379468C6D07993EA72F84D08D9F56@RTITMBSVM01.realtek.com.tw>
        <20180928092918.GC8323@redhat.com>
        <F7CD281DE3E379468C6D07993EA72F84D08DB7E3@RTITMBSVM01.realtek.com.tw>
        <20181002102957.GB25116@redhat.com>
        <a54dec4e-1164-f9c5-c791-3396a239eeba@lwfinger.net>
        <F7CD281DE3E379468C6D07993EA72F84D1728978@RTITMBSVM01.realtek.com.tw>
        <4b50e06f-2fd0-9378-d283-1ca6d02f9586@lwfinger.net>
        <87k1mx28dg.fsf@codeaurora.org> <20181004134252.GA20484@redhat.com>
Date:   Sat, 06 Oct 2018 15:16:45 +0300
In-Reply-To: <20181004134252.GA20484@redhat.com> (Stanislaw Gruszka's message
        of "Thu, 4 Oct 2018 15:42:53 +0200")
Message-ID: <87lg7bfexe.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Stanislaw Gruszka <sgruszka@redhat.com> writes:

> On Thu, Oct 04, 2018 at 03:39:55PM +0300, Kalle Valo wrote:
>> >> Can we put the configuration file in the firmware directory?
>> >> Should we package them into binary files? Or just put the raw data.
>> >>
>> >> We can test the performance for it. After we got the result, we
>> >> will make a decision
>> >> about it. And if we decide to put them in the firmware directory,
>> >> will send a patch.
>> >> For now, I think we can just leave them in the .c.
>> >
>> > Yes, you could put the configuration files in the firmware directory.
>> > I would put them in binary form, not as text files. That way the size
>> > would be smaller, and it would not be possible to alter them,
>> > particularly if the binary file is checksummed.
>> >
>> > It would likely be OK if only the agc table was stored in this way.
>> > That would take away about half of the lines in the 8822b table file.
>> 
>> So what's the worry here? The lines of source code, binary size or what?
>> 
>>  .../net/wireless/realtek/rtw88/rtw8822b_table.c    | 20783 +++++++++++++++++++
>> 
>> Looking at the diffstat rtw8822b_table.c seems to be 20 kLOC, IMHO it's
>> not that bad as it's just data. But of course I might be missing
>> something as I haven't checked patches yet.
>
> My concern was it's plenty of redundant data, for example:
>
>         0x81C, 0xFF000003,
>         0x81C, 0xFE000003,
>         0x81C, 0xFD020003,
>         0x81C, 0xFC040003,
>         0x81C, 0xFB060003,
>         0x81C, 0xFA080003,
>         0x81C, 0xF90A0003,
>         0x81C, 0xF80C0003,
>         0x81C, 0xF70E0003,
>         0x81C, 0xF6100003,
>
> Approx 10000 lines like this, braked by lines like this
>
>         0x90000012,     0x00000000,     0x40000000,     0x00000000,
>
> in more or less regular way.
>
> Not big deal, but perhaps this could be coded in much more compact way.

Sure, making it more compact makes sense to me.

But I don't see that as a strict requirement, that could be done also
after the driver is accepted. Do note that I haven't reviewed the driver
yet so I reserve the right to change my opinion :)

-- 
Kalle Valo