DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC02E2084D
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A052C6035F
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Stanislaw Gruszka <sgruszka@redhat.com>
Cc:     yhchuang@realtek.com, Larry.Finger@lwfinger.net,
        pkshih@realtek.com, tehuang@realtek.com,
        linux-wireless@vger.kernel.org
Subject: Re: [RFC v2 06/12] rtw88: fw and efuse files
References: <1538553748-26364-1-git-send-email-yhchuang@realtek.com>
        <1538553748-26364-7-git-send-email-yhchuang@realtek.com>
        <20181004104929.GA16819@redhat.com>
Date:   Sat, 06 Oct 2018 15:34:25 +0300
In-Reply-To: <20181004104929.GA16819@redhat.com> (Stanislaw Gruszka's message
        of "Thu, 4 Oct 2018 12:49:45 +0200")
Message-ID: <874ldzfe3y.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Stanislaw Gruszka <sgruszka@redhat.com> writes:

> On Wed, Oct 03, 2018 at 04:02:22PM +0800, yhchuang@realtek.com wrote:
>
>> +void rtw_add_rsvd_page(struct rtw_dev *rtwdev, enum rtw_rsvd_packet_type type,
>> +		       bool txdesc)
>> +{
>> +	struct rtw_rsvd_page *rsvd_pkt;
>> +
>> +	list_for_each_entry(rsvd_pkt, &rtwdev->rsvd_page_list, list) {
>> +		if (rsvd_pkt->type == type)
>> +			return;
>> +	}
>> +
>> +	rsvd_pkt = kmalloc(sizeof(*rsvd_pkt),
>> +			   in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
>
> It's never called from interrupt. You have to check kmalloc output value.

My recommendation is to always avoid in_interrupt().

-- 
Kalle Valo