DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2276F2087D
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9D5376024C
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Ajay Singh <ajay.kathat@microchip.com>
Cc:     <linux-wireless@vger.kernel.org>, <gregkh@linuxfoundation.org>,
        <ganesh.krishna@microchip.com>, <aditya.shankar@microchip.com>,
        <venkateswara.kaja@microchip.com>, <claudiu.beznea@microchip.com>,
        <adham.abozaeid@microchip.com>
Subject: Re: [RFC 00/19] wilc: added driver for wilc module
References: <1537957525-11467-1-git-send-email-ajay.kathat@microchip.com>
Date:   Sat, 06 Oct 2018 15:45:41 +0300
In-Reply-To: <1537957525-11467-1-git-send-email-ajay.kathat@microchip.com>
        (Ajay Singh's message of "Wed, 26 Sep 2018 15:55:06 +0530")
Message-ID: <87zhvrdz0q.fsf@kamboji.qca.qualcomm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Ajay Singh <ajay.kathat@microchip.com> writes:

> This patch set contains the driver files from 'driver/staging/wilc1000'.
> Renamed the driver from 'wilc1000' to 'wilc' to have generic name, as
> the same driver will be used by other wilc family members.

I'm worried that the name 'wilc' is just too generic, I liked the
original name wilc1000 much more. Quite often when we have a new
generation of wireless devices there's also a new driver, so in the long
run I'm worried that a generic name like 'wilc' could be a source of
confusion. I think it's much smaller problem if 'wilc1000' (the driver)
also supports wilc3000 (the device), people are already used to that.
And if there's ever a need for a new driver, you can call it 'wilc4000'
or whatever.

For example, I think good driver names are like 'mt76' or 'rtw88'
(currently under review).

-- 
Kalle Valo