DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABFB520878
Authenticated-By: 
From:   Tony Chuang <yhchuang@realtek.com>
To:     Stanislaw Gruszka <sgruszka@redhat.com>,
        Kalle Valo <kvalo@codeaurora.org>
CC:     "Larry.Finger@lwfinger.net" <Larry.Finger@lwfinger.net>,
        Pkshih <pkshih@realtek.com>, Andy Huang <tehuang@realtek.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [RFC v2 04/12] rtw88: trx files
Thread-Topic: [RFC v2 04/12] rtw88: trx files
Thread-Index: AQHUXXCabc6Uk9/+60ywbjX8pm9S+KUUjvoAgACHIyA=
Date:   Mon, 8 Oct 2018 09:35:13 +0000
Message-ID: <F7CD281DE3E379468C6D07993EA72F84D172BED1@RTITMBSVM01.realtek.com.tw>
References: <1538553748-26364-1-git-send-email-yhchuang@realtek.com>
 <1538553748-26364-5-git-send-email-yhchuang@realtek.com>
 <20181004131908.GD16819@redhat.com>
 <F7CD281DE3E379468C6D07993EA72F84D172A2BC@RTITMBSVM01.realtek.com.tw>
 <878t3bfe7o.fsf@kamboji.qca.qualcomm.com> <20181008091915.GC1961@redhat.com>
In-Reply-To: <20181008091915.GC1961@redhat.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> -----Original Message-----
> From: Stanislaw Gruszka [mailto:sgruszka@redhat.com]
> Sent: Monday, October 08, 2018 5:19 PM
> To: Kalle Valo
> Cc: Tony Chuang; Larry.Finger@lwfinger.net; Pkshih; Andy Huang;
> linux-wireless@vger.kernel.org
> Subject: Re: [RFC v2 04/12] rtw88: trx files
> 
> On Sat, Oct 06, 2018 at 03:32:11PM +0300, Kalle Valo wrote:
> > Tony Chuang <yhchuang@realtek.com> writes:
> >
> > >> > +	pkt_info->bmc = bmc;
> > >> > +	pkt_info->sec_type = sec_type;
> > >> > +	pkt_info->tx_pkt_size = skb->len;
> > >> > +	pkt_info->offset = chip->tx_pkt_desc_sz;
> > >> > +	pkt_info->qsel = skb->priority;
> > >>
> > >> Shouldn't be qsel somehow mapped from skb->priority ?
> > >
> > > Firmware handles it.
> >
> > What if meaning of skb->priority changes in the future? I don't think
> > it's safe to provide kernel internal values to firmware, you should do
> > some kind of mapping in the driver.
> 
> We already have some functions that do mapping:
> rtw_hw_queue_mapping(struct sk_buff *skb)
> and
> rtw_pci_get_tx_qsel(struct sk_buff *skb, u8 queue)
> Preasumly they should be used here as well.
> 
> Stanislaw
> 

Stanislaw is right, PCI will get the qsel again and overwrite it.
Maybe we should remove the extra qsel code in tx.c
BTW, skb->priority is mapped to TID 0-15 in mac80211, and that's
what we want to provide to the firmware.

Yan-Hsuan Chuang