Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BA4CC65C20 for ; Mon, 8 Oct 2018 11:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4BEF20858 for ; Mon, 8 Oct 2018 11:36:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="S4KbLZVG"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="S4KbLZVG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4BEF20858 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbeJHSrq (ORCPT ); Mon, 8 Oct 2018 14:47:46 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43374 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726689AbeJHSrq (ORCPT ); Mon, 8 Oct 2018 14:47:46 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DAC1C60BFA; Mon, 8 Oct 2018 11:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538998587; bh=qs6fidtiPh+LOjFE+XC75oJ3kTqMJWCZH88vfKxGc7A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S4KbLZVGscFIGpuEuP5Q13kRJThZDbcM+netzcDBg2k9lHTp+I76HrtwvrPXH9kKl kkMp/jmn+cVyXq1Xs/Pcd45Wx6NxPbyf8SSqEU3vqwWXYe3Qrcm7Ku34DMFETgdEyc +62oW7dzfu+Br+Wzcz/uYbte+lbG80dNFR82oGBA= Received: from purkki.adurom.net (purkki.adurom.net [80.68.90.206]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id BFFC46079B; Mon, 8 Oct 2018 11:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538998587; bh=qs6fidtiPh+LOjFE+XC75oJ3kTqMJWCZH88vfKxGc7A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S4KbLZVGscFIGpuEuP5Q13kRJThZDbcM+netzcDBg2k9lHTp+I76HrtwvrPXH9kKl kkMp/jmn+cVyXq1Xs/Pcd45Wx6NxPbyf8SSqEU3vqwWXYe3Qrcm7Ku34DMFETgdEyc +62oW7dzfu+Br+Wzcz/uYbte+lbG80dNFR82oGBA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BFFC46079B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Sergey Matyukevich Cc: "linux-wireless\@vger.kernel.org" , Igor Mitsyanko , Andrey Shevchenko Subject: Re: [PATCH 5/5] qtnfmac: add support for Topaz chipsets References: <20181008095551.18651-1-sergey.matyukevich.os@quantenna.com> <20181008095551.18651-6-sergey.matyukevich.os@quantenna.com> Date: Mon, 08 Oct 2018 14:36:24 +0300 In-Reply-To: <20181008095551.18651-6-sergey.matyukevich.os@quantenna.com> (Sergey Matyukevich's message of "Mon, 8 Oct 2018 09:56:05 +0000") Message-ID: <87in2cr7pj.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Sergey Matyukevich writes: > This patch adds support for QSR1000/QSR2000 family of chipsets > to qtnfmac_pcie platform driver. > > QSR1000/QSR2000 (aka Topaz) is a family of 80MHz, 11ac Wave2, > 4x4/2x4/2x2 chips, including single and dual band devices. > Depending on specific chip model and firmware in use, either > STA or both STA and AP modes are supported. > > Patch adds Topaz support to qtnfmac_pcie driver. It is possible > to enable both Topaz and Pearl support in kernel configuration. > In that case proper platform bus will be selected on probing > based on chip ID. > > Signed-off-by: Igor Mitsyanko > Signed-off-by: Sergey Matyukevich > Signed-off-by: Andrey Shevchenko [...] > --- a/drivers/net/wireless/quantenna/qtnfmac/qtn_hw_ids.h > +++ b/drivers/net/wireless/quantenna/qtnfmac/qtn_hw_ids.h > @@ -24,6 +24,7 @@ > /* PCIE Device IDs */ > > #define PCIE_DEVICE_ID_QTN_PEARL (0x0008) > +#define PCIE_DEVICE_ID_QTN_TOPAZ (0x0008) Same ids for both, is this really correct? -- Kalle Valo