DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EB832077C
Message-ID: <1539007219.3687.38.camel@sipsolutions.net>
Subject: Re: [RFC v3 12/12] rtw88: Kconfig & Makefile
From:   Johannes Berg <johannes@sipsolutions.net>
To:     yhchuang@realtek.com, kvalo@codeaurora.org
Cc:     Larry.Finger@lwfinger.net, pkshih@realtek.com, tehuang@realtek.com,
        sgruszka@redhat.com, linux-wireless@vger.kernel.org
Date:   Mon, 08 Oct 2018 16:00:19 +0200
In-Reply-To: <1538565659-29530-13-git-send-email-yhchuang@realtek.com> (sfid-20181003_132143_363210_BDF3D2A2)
References: <1538565659-29530-1-git-send-email-yhchuang@realtek.com>
         <1538565659-29530-13-git-send-email-yhchuang@realtek.com>
         (sfid-20181003_132143_363210_BDF3D2A2)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, 2018-10-03 at 19:20 +0800, yhchuang@realtek.com wrote:
> 
> +config RTW88_CORE
> +	tristate
> +	depends on RTW88
> +
> +config RTW88_PCI
> +	tristate
> +	depends on RTW88_CORE && PCI

Those "depends on" lines are misleading, I don't think select honours
that?

> +++ b/drivers/net/wireless/realtek/rtw88/Makefile
> @@ -0,0 +1,19 @@
> +obj-$(CONFIG_RTW88_CORE)	+= rtw88.o
> +rtw88-y += main.o \
> +	   mac80211.o \
> +	   debug.o \
> +	   tx.o \
> +	   rx.o \
> +	   mac.o \
> +	   phy.o \
> +	   efuse.o \
> +	   fw.o \
> +	   ps.o \
> +	   sec.o \
> +	   regd.o
> +
> +rtw88-$(CONFIG_RTW88_8822BE)	+= rtw8822b.o rtw8822b_table.o
> +rtw88-$(CONFIG_RTW88_8822CE)	+= rtw8822c.o rtw8822c_table.o
> +
> +obj-$(CONFIG_RTW88_PCI)		+= rtwpci.o
> +rtwpci-objs			:= pci.o

This is a weird split? Why even bother with two modules if everything
goes into the main "rtw88" module except for a single file?

johannes