DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBB9E20841
Message-ID: <1539007928.3687.49.camel@sipsolutions.net>
Subject: Re: [RFC v3 02/12] rtw88: core files
From:   Johannes Berg <johannes@sipsolutions.net>
To:     yhchuang@realtek.com, kvalo@codeaurora.org
Cc:     Larry.Finger@lwfinger.net, pkshih@realtek.com, tehuang@realtek.com,
        sgruszka@redhat.com, linux-wireless@vger.kernel.org
Date:   Mon, 08 Oct 2018 16:12:08 +0200
In-Reply-To: <1538565659-29530-3-git-send-email-yhchuang@realtek.com> (sfid-20181003_132138_423244_A2698272)
References: <1538565659-29530-1-git-send-email-yhchuang@realtek.com>
         <1538565659-29530-3-git-send-email-yhchuang@realtek.com>
         (sfid-20181003_132138_423244_A2698272)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, 2018-10-03 at 19:20 +0800, yhchuang@realtek.com wrote:

If you use bitmaps for the security CAM index tracking,

this:

> +u32 rtw_sec_installed_cam_num(struct rtw_sec_desc *sec)
> +{
> +	u32 cnt = 0;
> +	int i;
> +
> +	for (i = 0; i < sec->total_cam_num; i++)
> +		if (sec->cam_table[i].used)
> +			cnt++;
> +
> +	return cnt;
> +}

becomes hweight(), and this:

> +int rtw_sec_get_free_cam(struct rtw_sec_desc *sec)
> +{
> +	int i;
> +
> +	/* if default key search is enabled, the first 4 cam entries
> +	 * are used to direct map to group key with its key->key_idx, so
> +	 * driver should use cam entries after 4 to install pairwise key
> +	 */
> +	i = sec->default_key_search ? RTW_SEC_DEFAULT_KEY_NUM : 0;
> +	for (; i < sec->total_cam_num; i++)
> +		if (!sec->cam_table[i].used)
> +			return i;
> +
> +	return i;
> +}

just find_next_zero_bit().

Your code hard-codes an assumption that default_key_search is true
though, afaict, so you can probably just remove that.

johannes