DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C51C214C4
MIME-Version: 1.0
References: <5C44048D-0676-48E6-9AA3-F327839F13E5@theobroma-systems.com>
In-Reply-To: <5C44048D-0676-48E6-9AA3-F327839F13E5@theobroma-systems.com>
From:   Franky Lin <franky.lin@broadcom.com>
Date:   Tue, 9 Oct 2018 11:59:19 -0700
Message-ID: <CA+8PC_dkJAPR2C0DsOWRb__RrijbZZ43MM1gtKGjsMxdTGwsZQ@mail.gmail.com>
Subject: Re: brcmfmac with BCM4359 on arm64 (RK3399) and SDIO
To:     christoph.muellner@theobroma-systems.com
Cc:     Arend Van Spriel <arend.vanspriel@broadcom.com>,
        "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
        <linux-wireless@vger.kernel.org>,
        "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
        <brcm80211-dev-list.pdl@broadcom.com>,
        brcm80211-dev-list <brcm80211-dev-list@cypress.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Christoph,

On Tue, Oct 9, 2018 at 11:10 AM Christoph M=C3=BCllner
<christoph.muellner@theobroma-systems.com> wrote:
>
> Hi Arend,
>
> recently I got an SDIO module, which includes a BCM4359.
> I tried to get it up and running via the SD card interface
> on a RK3399 SoC and succeeded in doing so with
> bcmdhd.1.579.77.41.x and a vendor kernel (based on Linux 4.4).
> All that was necessary was configure BCMDHD to run with
> in-band IRQs and use a GPIO as gpio_wl_reg_on.
>
> Since I can run a mainline kernel as well, I gave it a try and
> tried brcmfmac on Linux 4.19-rc7. As the BCM4359 is not in
> the list of supported SDIO devices, but is supported USB device,
> I've created a patch (attached), which adds the support for that device.
> Additionally I've patched my DTS to include the WL_REG_ON
> pin as part of mmc-pwrseq-simple's reset-gpios and added
> a bcm4329-fmac node in the mmc node.
>
> During bootup I see messages from brcmfmac, which indicate
> that the BCM4359 has been found, but loading the nvram file
> continuously fails:
>
> > [    5.993741] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac435=
9-sdio for chip BCM4359/9
> > [...]
> > [    7.987167] brcmfmac: brcmf_sdiod_ramrw: membytes transfer failed
> > [    8.008715] brcmfmac: brcmf_sdio_verifymemory: error -84 on reading =
2048 membytes at 0x0025f1f0
> > [    8.021182] brcmfmac: brcmf_sdio_download_firmware: dongle nvram fil=
e download failed

Does it always fail at nvram verification? If so please help to get
the address and varsz in brcmf_sdio_download_nvram. Also their
equivalent in bcmdhd which should be varaddr and varsize in
dhdsdio_write_vars.

Thanks,
--Franky

> That -84 means EILSEQ, which is the error value, which represents
> a CRC error during SDIO data exchange (returned by the function dw_mci_da=
ta_complete()
> in the MMC driver).
>
> To address this, I've reduced the clock speed (in several steps) to 400 k=
Hz
> (and verified the clock signal on an oscilloscope), but the issue persist=
s.
> I've also tried to use Linux 4.14.74, where I see the same issue.
>
> I can confirm that the MMC interface works in general (I can use an SD ca=
rd
> to host my rootfs).
>
> FWIW I'm using the same exact same firmware and nvram file for the DHD dr=
iver
> and the brcmfmac.
>
> Do you have any ideas how to debug this issue?
>
> Thanks,
> Christoph
>
>
>
> --
> Christoph M=C3=BCllner
> Theobroma Systems Design und Consulting GmbH
> Seestadtstra=C3=9Fe 27 (Aspern IQ), 1220 Wien, Austria
> Phone: +43 1 236 98 93-409, Fax: +43 1 236 98 93-9
> http://www.theobroma-systems.com
>
>
>
>