Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97679C64EB0 for ; Tue, 9 Oct 2018 20:02:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A122213A2 for ; Tue, 9 Oct 2018 20:02:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A122213A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sipsolutions.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727620AbeJJDVd (ORCPT ); Tue, 9 Oct 2018 23:21:33 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:58620 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727486AbeJJDVd (ORCPT ); Tue, 9 Oct 2018 23:21:33 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1g9yDY-0002Lh-H2; Tue, 09 Oct 2018 22:02:56 +0200 Message-ID: <1539115363.3687.138.camel@sipsolutions.net> Subject: Re: [PATCH 03/19] wilc: add host_interface.h From: Johannes Berg To: Adham.Abozaeid@microchip.com, Ajay.Kathat@microchip.com, linux-wireless@vger.kernel.org Cc: kvalo@codeaurora.org, gregkh@linuxfoundation.org, Ganesh.Krishna@microchip.com, Aditya.Shankar@microchip.com, Venkateswara.Kaja@microchip.com, Claudiu.Beznea@microchip.com Date: Tue, 09 Oct 2018 22:02:43 +0200 In-Reply-To: <5BBD08FB.1070302@microchip.com> References: <1537957525-11467-1-git-send-email-ajay.kathat@microchip.com> <1537957525-11467-4-git-send-email-ajay.kathat@microchip.com> <1539008417.3687.57.camel@sipsolutions.net> <1539081379.3687.112.camel@sipsolutions.net> <1d77cb4d-92c9-0ea4-bdd3-f16a2421406f@microchip.com> <1539085569.3687.115.camel@sipsolutions.net> <092b38f4-8153-9abd-890a-a42454f22154@microchip.com> <5BBCF51A.2060806@microchip.com> <1539112463.3687.131.camel@sipsolutions.net> <5BBD08FB.1070302@microchip.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2018-10-09 at 20:01 +0000, Adham.Abozaeid@microchip.com wrote: > > Do you mean that it can also be used for probing specific networks even if they are broadcasting their SSID? Yes. > I think this might be a possible case if the user is trying to limit the scan results to a specific network. No. Don't do any filtering based on this. Basically the only thing you should do with the (list of) SSIDs is to send a probe request containing each of them. Userspace/cfg80211 will take care that the usual empty (wildcard) SSID is included in the list, so don't send one with that by yourself, just iterate the list. If you only support sending one probe request in each scan request, then set the max # of SSIDs supported to 1, otherwise set it to the maximum (or a reasonable limit like 20 if it's in software). johannes