DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0517520835
Message-ID: <1539241383.3687.191.camel@sipsolutions.net>
Subject: Re: [PATCH 13/19] wilc: add linux_wlan.c
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Ajay Singh <ajay.kathat@microchip.com>,
        linux-wireless@vger.kernel.org
Cc:     kvalo@codeaurora.org, gregkh@linuxfoundation.org,
        ganesh.krishna@microchip.com, aditya.shankar@microchip.com,
        venkateswara.kaja@microchip.com, claudiu.beznea@microchip.com,
        adham.abozaeid@microchip.com
Date:   Thu, 11 Oct 2018 09:03:03 +0200
In-Reply-To: <45c17836-9362-d2ef-9647-514b5c75ec93@microchip.com>
References: <1537957525-11467-1-git-send-email-ajay.kathat@microchip.com>
         <1537957525-11467-14-git-send-email-ajay.kathat@microchip.com>
         <1539009674.3687.75.camel@sipsolutions.net>
         <45c17836-9362-d2ef-9647-514b5c75ec93@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Thu, 2018-10-11 at 12:30 +0530, Ajay Singh wrote:
> 
> > > +	if (queue_count > FLOW_CONTROL_UPPER_THRESHOLD) {
> > > +		netif_stop_queue(wilc->vif[0]->ndev);
> > > +		netif_stop_queue(wilc->vif[1]->ndev);
> > > +	}
> > 
> > It seems like a pretty bad idea to hard-code two interfaces, we do
> > dynamic addition/removal these days, in *particular* for P2P.
> > 
> 
> Did you mean it not good to call stop queue for both the interfaces.
> Can you please provide some more details about this comments.

No, I mean you should be more dynamic and have e.g. a list of interfaces
(actually, you can use cfg80211's list, I believe!), instead of hard-
coding that you have "wlan0" and "p2p0".

johannes