Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D330C43441 for ; Fri, 12 Oct 2018 09:30:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E561520868 for ; Fri, 12 Oct 2018 09:30:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="R09pTZT3"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="R09pTZT3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E561520868 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbeJLRBy (ORCPT ); Fri, 12 Oct 2018 13:01:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39240 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728027AbeJLRBy (ORCPT ); Fri, 12 Oct 2018 13:01:54 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 68F54605A4; Fri, 12 Oct 2018 09:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539336622; bh=zFFCV8dF/s0kQeAIi9JmB7de/s77Qvgt1PYPogvaYNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R09pTZT3VQ9i0H0h1Zn9tkF9PurIvzRZp+A7LNMtmn5pxmghnKSLGi0yew/BSbpaP ZY4pnfD/znuBYMGcuKiEVfkEdHGqz7Cd5h19+n+lRmq+9Ds7rbtNlSGhnVCAe7q62R 3xY70mDzISRjfheovV/eTdfY5AhCvn0IXYX032l0= Received: from govinds-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: govinds@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8F84D60209; Fri, 12 Oct 2018 09:30:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539336622; bh=zFFCV8dF/s0kQeAIi9JmB7de/s77Qvgt1PYPogvaYNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R09pTZT3VQ9i0H0h1Zn9tkF9PurIvzRZp+A7LNMtmn5pxmghnKSLGi0yew/BSbpaP ZY4pnfD/znuBYMGcuKiEVfkEdHGqz7Cd5h19+n+lRmq+9Ds7rbtNlSGhnVCAe7q62R 3xY70mDzISRjfheovV/eTdfY5AhCvn0IXYX032l0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8F84D60209 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=govinds@codeaurora.org From: Govind Singh To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Govind Singh Subject: [PATCH 3/3] ath10k: Request credit report if flow control enabled on ep Date: Fri, 12 Oct 2018 15:00:03 +0530 Message-Id: <20181012093003.11932-4-govinds@codeaurora.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181012093003.11932-1-govinds@codeaurora.org> References: <20181012093003.11932-1-govinds@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org FW credit flow control is enabled for only WMI ctrl service(CE3) but credit update is requested unconditionally on all HTC services as part of HTC tx in CE3/CE0/CE4. This is causing WOW failure as FW is not expecting credit report request on other end-points(CE0/CE4). Request credit report only on those endpoints where credit flow control is enabled. Testing: Tested on WCN3990 HW. Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1. Signed-off-by: Govind Singh --- drivers/net/wireless/ath/ath10k/htc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c index 8902720b4e49..31f1a316be7c 100644 --- a/drivers/net/wireless/ath/ath10k/htc.c +++ b/drivers/net/wireless/ath/ath10k/htc.c @@ -87,7 +87,8 @@ static void ath10k_htc_prepare_tx_skb(struct ath10k_htc_ep *ep, hdr->eid = ep->eid; hdr->len = __cpu_to_le16(skb->len - sizeof(*hdr)); hdr->flags = 0; - hdr->flags |= ATH10K_HTC_FLAG_NEED_CREDIT_UPDATE; + if (ep->tx_credit_flow_enabled) + hdr->flags |= ATH10K_HTC_FLAG_NEED_CREDIT_UPDATE; spin_lock_bh(&ep->htc->tx_lock); hdr->seq_no = ep->seq_no++; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project