Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A211C43441 for ; Fri, 12 Oct 2018 11:38:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60A3120868 for ; Fri, 12 Oct 2018 11:38:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60A3120868 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727995AbeJLTKo (ORCPT ); Fri, 12 Oct 2018 15:10:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38940 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726917AbeJLTKo (ORCPT ); Fri, 12 Oct 2018 15:10:44 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 12DBB300186F; Fri, 12 Oct 2018 11:38:43 +0000 (UTC) Received: from localhost (unknown [10.40.205.242]) by smtp.corp.redhat.com (Postfix) with ESMTP id A3FF68497C; Fri, 12 Oct 2018 11:38:42 +0000 (UTC) Date: Fri, 12 Oct 2018 13:38:41 +0200 From: Stanislaw Gruszka To: Tom Psyborg Cc: linux-wireless@vger.kernel.org, Daniel Golle , Mathias Kresin , Felix Fietkau Subject: Re: [PATCH v4 6/8] rt2800: enable TX_PIN_CFG_RFRX_EN only for MT7620 Message-ID: <20181012113841.GC2118@redhat.com> References: <1539334591-9965-1-git-send-email-sgruszka@redhat.com> <1539334591-9965-7-git-send-email-sgruszka@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 12 Oct 2018 11:38:43 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, Oct 12, 2018 at 12:52:13PM +0200, Tom Psyborg wrote: > is there some specific reason to read TX_PIN_CFG register on RT6352, > rather than just null it before programming in tx values like in other > chips? I don't remember the details, but Daniel explained that tere are some bits in the TX_PIN_CFG register that have to be preserved for RT6352. Regards Stanislaw