DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 314C621470
MIME-Version: 1.0
References: <1539289141-13689-1-git-send-email-dan.haab@luxul.com> <cf6f8b8a-2638-7d32-d3b1-0fc21f74a0df@broadcom.com>
In-Reply-To: <cf6f8b8a-2638-7d32-d3b1-0fc21f74a0df@broadcom.com>
From:   Rip Route <riproute@gmail.com>
Date:   Fri, 12 Oct 2018 11:02:55 -0600
Message-ID: <CALZrXO=nwHnj0tqBwoZh=bVD_iETSvbBezE6wjMDQcUoJvTB0w@mail.gmail.com>
Subject: Re: [PATCH] brcmfmac: support STA info struct v7
To:     Arend van Spriel <arend.vanspriel@broadcom.com>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>, davem@davemloft.net,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Chung-Hsien Hsu <stanley.hsu@cypress.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com, Dan Haab <dan.haab@luxul.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, Oct 12, 2018 at 3:02 AM Arend van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
> On 10/11/2018 10:19 PM, Dan Haab wrote:
> > The newest firmwares provide STA info using v7 of the struct. As v7
> > isn't backward compatible, a union is needed.
> >
> > Even though brcmfmac does not use any of the new info it's important to
> > provide the proper struct buffer. Without this change new firmwares will
> > fallback to the very limited v3 instead of something in between such as
> > v4.
>
> Hi Dan,
>
> I don't have a real problem with adding this v7 stuff, but it looks
> different from what I have here which has additional fields. For what
> new firmwares and more importantly what devices do you need this. I only
> know it is used for 43684, which we do not support with brcmfmac (yet).

Arend,

This is to be used with firmwares we generated from the SDK recommended
to me by by Broadcom, 7.14.170.34. These firmwares are used on these
Luxul devices: XWR-3150v2 and XAP-1610.

Cheers,
Dan