DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDBB120895
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2E3A060600
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
        Lior David <liord@codeaurora.org>, luca@coelho.fi,
        Etan Cohen <etancohen@google.com>,
        Roy Want <roywant@google.com>,
        Arend Van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC v3] cfg80211: add peer measurement with FTM API
References: <20181012100827.24195-1-johannes@sipsolutions.net>
Date:   Sat, 13 Oct 2018 12:55:00 +0300
In-Reply-To: <20181012100827.24195-1-johannes@sipsolutions.net> (Johannes
        Berg's message of "Fri, 12 Oct 2018 12:08:27 +0200")
Message-ID: <87tvlqp3wr.fsf@purkki.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Johannes Berg <johannes@sipsolutions.net> writes:

> From: Johannes Berg <johannes.berg@intel.com>
>
> Add a new "peer measurement" API, that can be used to measure
> certain things related to a peer. Right now, only implement
> FTM (flight time measurement) over it, but the idea is that
> it'll be extensible to also support measuring the necessary
> things to calculate e.g. angle-of-arrival for WiGig.
>
> The API is structured to have a generic list of peers and
> channels to measure with/on, and then for each of those a
> set of measurements (again, only FTM right now) to perform.
>
> Results are sent to the requesting socket, including a final
> complete message.
>
> Closing the controlling netlink socket will abort a running
> measurement.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> v3:
>  - add a bit to report "final" for partial results
>  - remove list keeping etc. and just unicast out the results
>    to the requester (big code reduction ...)
>  - also send complete message unicast, and as a result
>    remove the multicast group
>  - separate out struct cfg80211_pmsr_ftm_request_peer
>    from struct cfg80211_pmsr_request_peer
>  - document timeout == 0 if no timeout
>  - disallow setting timeout nl80211 attribute to 0,
>    must not include attribute for no timeout
>  - make MAC address randomization optional
>  - change num bursts exponent default to 0 (1 burst, rather
>    rather than the old default of 15==don't care)

[...]

> @@ -3176,6 +3361,8 @@ struct cfg80211_ftm_responder_stats {
>   *
>   * @get_ftm_responder_stats: Retrieve FTM responder statistics, if available.
>   *	Statistics should be cumulative, currently no way to reset is provided.
> + * @start_pmsr: start peer measurement (e.g. FTM)
> + * @abort_pmsr: abort peer measurement
>   */
>  struct cfg80211_ops {
>  	int	(*suspend)(struct wiphy *wiphy, struct cfg80211_wowlan *wow);

It would be nice to document if these ops can sleep or not.

-- 
Kalle Valo