DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D33E920645
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DCB5B605A4
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc:     "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>,
        Andrey Shevchenko <ashevchenko@quantenna.com>
Subject: Re: [PATCH 5/5] qtnfmac: add support for Topaz chipsets
References: <20181008095551.18651-1-sergey.matyukevich.os@quantenna.com>
        <20181008095551.18651-6-sergey.matyukevich.os@quantenna.com>
Date:   Sat, 13 Oct 2018 15:14:46 +0300
In-Reply-To: <20181008095551.18651-6-sergey.matyukevich.os@quantenna.com>
        (Sergey Matyukevich's message of "Mon, 8 Oct 2018 09:56:05 +0000")
Message-ID: <87murioxft.fsf@purkki.adurom.net>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Sergey Matyukevich <sergey.matyukevich.os@quantenna.com> writes:

> This patch adds support for QSR1000/QSR2000 family of chipsets
> to qtnfmac_pcie platform driver.
>
> QSR1000/QSR2000 (aka Topaz) is a family of 80MHz, 11ac Wave2,
> 4x4/2x4/2x2 chips, including single and dual band devices.
> Depending on specific chip model and firmware in use, either
> STA or both STA and AP modes are supported.
>
> Patch adds Topaz support to qtnfmac_pcie driver. It is possible
> to enable both Topaz and Pearl support in kernel configuration.
> In that case proper platform bus will be selected on probing
> based on chip ID.
>
> Signed-off-by: Igor Mitsyanko <igor.mitsyanko.os@quantenna.com>
> Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
> Signed-off-by: Andrey Shevchenko <ashevchenko@quantenna.com>

[...]

> +config QTNFMAC_TOPAZ_PCIE
> +	tristate "Quantenna QSR1000/QSR2000 PCIe support"
> +	default n
> +	depends on PCI && CFG80211
> +	select QTNFMAC
> +	select FW_LOADER
> +	select CRC32
> +	help
> +	  This option adds support for wireless adapters based on Quantenna
> +	  802.11ac QSR1000/QSR2000 (aka Topaz) FullMAC chipset
> +	  running over PCIe.
> +
> +	  If you choose to build it as a module, two modules will be built:
> +	  qtnfmac.ko and qtnfmac_pcie.ko.

I'm not really fond of adding a Kconfig option for every supported
hardware version unless there are very good reasons (memory savings
etc). So is this really needed?

A much better approach would be to have a generic QTNFMAC_PCIE option
which can be used to include or exclude all PCI code.

-- 
Kalle Valo