Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32895C28CF8 for ; Sat, 13 Oct 2018 17:29:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD23B20835 for ; Sat, 13 Oct 2018 17:29:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Nz0trrv/"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="opgaU3Ti" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD23B20835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726890AbeJNBHM (ORCPT ); Sat, 13 Oct 2018 21:07:12 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49368 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726559AbeJNBHM (ORCPT ); Sat, 13 Oct 2018 21:07:12 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2923960116; Sat, 13 Oct 2018 17:29:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539451752; bh=rqVEMtJx07H6vsPn5VwQgd2btub2P1xQB47KnuWxq10=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Nz0trrv/+vfvBmOS5X3523g03WZM08x+yRgmUJeLjuhWBouq+uT29JPKz6xwgOOmb GF5pOhAPcHr21u3t+fT8vhVFCdvPBKeaBUomp7oNSZFjhsG5TZpYp0df1rTWDwfunb iqTs8bSJIpJdG1fD1LUsU6s+WuaFrbvx6mIattDA= Received: from potku.adurom.net (88-114-240-228.elisa-laajakaista.fi [88.114.240.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0CE6460116; Sat, 13 Oct 2018 17:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1539451751; bh=rqVEMtJx07H6vsPn5VwQgd2btub2P1xQB47KnuWxq10=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=opgaU3TiMVnxUiNxC6gTHcwGK8lNp4FWQMc0aycnCRu0xjR2CfRRCivK4G5ICG98P 8SyeGAT0w+HRUrBYadBt+auT25YzxA3nk9trAWmc0WgQoH63nDGpNOmptPuimpl4l1 PdVP4KP2cJ+domOygK1KVNOVWWp9HJYt1B/bRBRg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0CE6460116 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wil6210: fix debugfs_simple_attr.cocci warnings From: Kalle Valo In-Reply-To: <1538737646-118337-1-git-send-email-yuehaibing@huawei.com> References: <1538737646-118337-1-git-send-email-yuehaibing@huawei.com> To: YueHaibing Cc: Maya Erez , YueHaibing , , , , User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20181013172912.2923960116@smtp.codeaurora.org> Date: Sat, 13 Oct 2018 17:29:12 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Signed-off-by: YueHaibing > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. f9dca154a4e4 wil6210: fix debugfs_simple_attr.cocci warnings -- https://patchwork.kernel.org/patch/10627883/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches