DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EFAB208B3
MIME-Version: 1.0
References: <1537766878-11238-1-git-send-email-vnaralas@codeaurora.org> <87va672nib.fsf@kamboji.qca.qualcomm.com>
In-Reply-To: <87va672nib.fsf@kamboji.qca.qualcomm.com>
From:   Kan Yan <kyan@google.com>
Date:   Mon, 15 Oct 2018 14:56:33 -0700
Message-ID: <CA+iem5v7HUuPeXv5bG9=xhW_yhyUvq4R+Ybw+wBm1Niha77iqA@mail.gmail.com>
Subject: Re: [PATCH] ath10k: Add wrapper function to ath10k debug
To:     kvalo@codeaurora.org
Cc:     vnaralas@codeaurora.org, ath10k@lists.infradead.org,
        linux-wireless@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

> Johannes had an interesting idea to use trace_ath10k_log_dbg_enabled().
> Could you investigate if that would work? That way we might get the
> performance improvement even when is enabled CONFIG_ATH10K_TRACING (but
> actual trace point is disabled, of course).

That's a good idea. This patch was originally made for Google Wifi's
3.18 kernel and It does use trace_ath10k_log_dbg_enabled():
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/391891
+#define ath10k_dbg(ar, mask, format, ...)                              \
+       do {                                                            \
+               if (unlikely((ath10k_debug_mask & mask) ||              \
+                             trace_ath10k_log_dbg_enabled())) {        \
+                       __ath10k_dbg(ar, mask, format, ##__VA_ARGS__);  \
+               }                                                       \
+       } while (0)