DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1776A205F4
Message-ID: <ffa3dae454a5e0be00f6001845d3bca24e96a52e.camel@sipsolutions.net>
Subject: Re: [RFC v3] cfg80211: add peer measurement with FTM API
From:   Johannes Berg <johannes@sipsolutions.net>
To:     linux-wireless@vger.kernel.org
Cc:     Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
        Lior David <liord@codeaurora.org>, luca@coelho.fi,
        Etan Cohen <etancohen@google.com>,
        Roy Want <roywant@google.com>,
        Arend Van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>
Date:   Tue, 16 Oct 2018 11:15:22 +0200
In-Reply-To: <20181012100827.24195-1-johannes@sipsolutions.net> (sfid-20181012_120854_265156_44F5E1AA)
References: <20181012100827.24195-1-johannes@sipsolutions.net>
         (sfid-20181012_120854_265156_44F5E1AA)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk


> v3:
>  - add a bit to report "final" for partial results
>  - remove list keeping etc. and just unicast out the results
>    to the requester (big code reduction ...)
>  - also send complete message unicast, and as a result
>    remove the multicast group
>  - separate out struct cfg80211_pmsr_ftm_request_peer
>    from struct cfg80211_pmsr_request_peer
>  - document timeout == 0 if no timeout
>  - disallow setting timeout nl80211 attribute to 0,
>    must not include attribute for no timeout
>  - make MAC address randomization optional
>  - change num bursts exponent default to 0 (1 burst, rather
>    rather than the old default of 15==don't care)

Forgot to say ... I didn't make the channel optional (yet), because I
think that doing so now could possibly cause an issue where it's
required for some devices and not required for others, unless we can do
lookups in cfg80211. But if we can do it there, then userspace can also
easily do it (station dump is the only data cfg80211 has), so then
there's not that much point ...

I think we could relax this later if we really needed to.

johannes