DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B8252150D
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 17 Oct 2018 16:51:44 +0530
From:   Rakesh Pillai <pillair@codeaurora.org>
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
        Surabhi Vishnoi <svishnoi@codeaurora.org>
Subject: Re: [PATCH] ath10k: Fill the channel survey results for WCN3990
 correctly
In-Reply-To: <87murj2mc0.fsf@kamboji.qca.qualcomm.com>
References: <1538564267-19863-1-git-send-email-pillair@codeaurora.org>
 <20181012143434.3F49060A98@smtp.codeaurora.org>
 <87murj2mc0.fsf@kamboji.qca.qualcomm.com>
Message-ID: <c825412eeccfee7a3ca6ebe0b9e68ea8@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Kalle,

I have removed the clk_freq variable and now there will be u32 division 
only.
This change has been sent in v2.

Thanks,
Rakesh Pillai.

On 2018-10-12 21:23, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
> 
>> Rakesh Pillai <pillair@codeaurora.org> wrote:
>> 
>>> The host driver currently expects the channel info event to be
>>> received in pairs for all the channels, i.e. the first
>>> chan_info event for a particular channel will not have the
>>> COMPLETE flag set and the second chan_info event for the
>>> same channel will have the COMPLETE flag set.
>>> 
>>> The HL2.0 firmware sends only one channel info event per channel
>>> which is scanned without the COMPLETE flag set. After sending the
>>> chan_info_event for all the channels, the HL2.0 firmware sends a
>>> chan_info_event with COMPLETE flag set to indicate the completion
>>> of the channel info event.
>>> 
>>> The firmware does not indicate this behavior with any service bitmap
>>> and hence a new firmware feature flag is used to handle the modified
>>> parsing of the channel info events, in the host driver, for the
>>> firmware which sends single channel info event per scanned channel.
>>> 
>>> Tested HW: WCN3990
>>> Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1
>>> 
>>> Co-developed-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
>>> Signed-off-by: Surabhi Vishnoi <svishnoi@codeaurora.org>
>>> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>> 
>> Kbuild bot reported some errors:
>> 
>>>> ERROR: "__udivdi3" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] 
>>>> undefined!
>>>> ERROR: "__divdi3" [drivers/net/wireless/ath/ath10k/ath10k_core.ko] 
>>>> undefined!
>> 
>> Need to investigate those if they are valid or problem with the bot.
> 
> Arnd explained the problem in the other thread:
> 
>   "I think the problem is that 'clock_freq' is a 'u64', which means we
>    can't use a normal 32-bit division. It looks like it cannot actually
>    go beyond the range of a u32, so changing the type should be
>    sufficient."
> 
> Please investigate that and submit v2.