DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A3E420779
Message-ID: <f1f5e0839f4b1b68510b9db398995c859a19a19e.camel@sipsolutions.net>
Subject: Re: 4.18.16: memory leak in sta_set_sinfo
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Johannes Stezenbach <js@sig21.net>,
        Arend van Spriel <aspriel@gmail.com>
Cc:     linux-wireless@vger.kernel.org
Date:   Mon, 22 Oct 2018 10:25:07 +0200
In-Reply-To: <20181022080214.GA6379@sig21.net> (sfid-20181022_102320_063301_39ACC5C2)
References: <20181022080214.GA6379@sig21.net>
         (sfid-20181022_102320_063301_39ACC5C2)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-10-22 at 10:02 +0200, Johannes Stezenbach wrote:
> 
>     [<00000000b7b13d1a>] sta_set_sinfo+0x634/0x900 [mac80211]
>     [<00000000a74db622>] ieee80211_get_station+0x50/0x70 [mac80211]
>     [<000000009fd8a7aa>] cfg80211_wext_giwrate+0x111/0x2b0 [cfg80211]

> I guess it relates to
> 0fdf1493b41 " mac80211: allocate and fill tidstats only when needed"
> which Fixes: 8689c051a201 ("cfg80211: dynamically allocate per-tid stats for station info")

Yes, you're using wext which we don't any more, so we didn't see this.

However, it's already fixed:

commit 848e616e66d4592fe9afc40743d3504deb7632b4
Author: Stefan Seyfried <seife+kernel@b1-systems.com>
Date:   Sun Sep 30 12:53:00 2018 +0200

    cfg80211: fix wext-compat memory leak

Hopefully that'll eventually propagate to stable.

johannes