DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA6F320658
Date:   Mon, 22 Oct 2018 10:35:52 +0200
From:   Johannes Stezenbach <js@sig21.net>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     Arend van Spriel <aspriel@gmail.com>,
        linux-wireless@vger.kernel.org
Subject: Re: 4.18.16: memory leak in sta_set_sinfo
Message-ID: <20181022083552.GA6878@sig21.net>
References: <20181022080214.GA6379@sig21.net>
 <f1f5e0839f4b1b68510b9db398995c859a19a19e.camel@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f1f5e0839f4b1b68510b9db398995c859a19a19e.camel@sipsolutions.net>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, Oct 22, 2018 at 10:25:07AM +0200, Johannes Berg wrote:
> On Mon, 2018-10-22 at 10:02 +0200, Johannes Stezenbach wrote:
> > 
> >     [<00000000b7b13d1a>] sta_set_sinfo+0x634/0x900 [mac80211]
> >     [<00000000a74db622>] ieee80211_get_station+0x50/0x70 [mac80211]
> >     [<000000009fd8a7aa>] cfg80211_wext_giwrate+0x111/0x2b0 [cfg80211]
> 
> > I guess it relates to
> > 0fdf1493b41 " mac80211: allocate and fill tidstats only when needed"
> > which Fixes: 8689c051a201 ("cfg80211: dynamically allocate per-tid stats for station info")
> 
> Yes, you're using wext which we don't any more, so we didn't see this.

Yes, disappointing that conky still uses wext.

> However, it's already fixed:
> 
> commit 848e616e66d4592fe9afc40743d3504deb7632b4
> Author: Stefan Seyfried <seife+kernel@b1-systems.com>
> Date:   Sun Sep 30 12:53:00 2018 +0200
> 
>     cfg80211: fix wext-compat memory leak
> 
> Hopefully that'll eventually propagate to stable.

Good to know it's fixed, but "hopefully" makes me wonder,
I'd love to hear the confirmation that it's been queued.
OTOH I'll apply the patch locally and eventually move to 4.19,
so what gives...

Thanks,
Johannes