DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB2A720652
Message-ID: <0ead002730ad2902d87c77cc3abeb9c21c4a0930.camel@sipsolutions.net>
Subject: Re: mac80211 keeps trying to start ampdu session??
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
Cc:     linux-wireless@vger.kernel.org,
        Arend van Spriel <aspriel@gmail.com>
Date:   Tue, 23 Oct 2018 10:18:54 +0200
In-Reply-To: <20181023104404.795619aa@manjaro> (sfid-20181023_094412_429654_F9659EF4)
References: <20181023104404.795619aa@manjaro>
         (sfid-20181023_094412_429654_F9659EF4)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 2018-10-23 at 10:44 +0300, Ali MJ Al-Nasrawy wrote:
> Hi,
> 
> I am trying to debug brcmsmac wireless driver for spamming the log with
> the message:
> [...] START: tid 2 is not agg'able
> for it does not support AMPDU aggreggation for TID 2.
> 
> And after quick tracing, I found that mac80211 keeps trying to start
> AMPDU session for the _same TID and STA_ despite that the driver returns
> non-zero code via its ampdu_action callback and that non-zero return
> codes are recognized as the "HW unavailable" for such session
> (agg-tx.c:ieee80211_tx_ba_session_handle_start)
> 
> So, Is that an expected behaviour from mac80211 or not??

This depends on the rate control algorithm, it triggers this.

I think - perhaps depending on the return value - mac80211 *does* give
up eventually, but not really sure.

Perhaps just remove the message?

johannes