DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD5B020665
Message-ID: <67d0b8ec7d01ac452dfa5a1a8c2389adaa221d6b.camel@sipsolutions.net>
Subject: Re: Where to report mpdus tx vs failed?
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Ben Greear <greearb@candelatech.com>,
        Steve deRosier <derosier@gmail.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>
Date:   Tue, 23 Oct 2018 11:36:12 +0200
In-Reply-To: <ae110050-1eec-25c4-57ba-86b42aae2930@candelatech.com>
References: <104c8823-e867-6244-a528-979482c7fccc@candelatech.com>
         <CALLGbRKOLVg0bLhezLkEA_MPCg_S1L-drJNy3fSWxPJXJV+ajQ@mail.gmail.com>
         <93888bdc-b27d-78db-7fde-e881fa74c99b@candelatech.com>
         <c46e9b859318574a3b5ce7e1dbdf48404892d101.camel@sipsolutions.net>
         <512247ba69be323b6cef3b17ccd6957343acebd1.camel@sipsolutions.net>
         <ae110050-1eec-25c4-57ba-86b42aae2930@candelatech.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-10-22 at 10:16 -0700, Ben Greear wrote:

> > > We have NL80211_STA_INFO_TX_RETRIES, shouldn't you be able to capture it
> > > there?
> > 
> > Or, per TID, NL80211_TID_STATS_TX_MSDU_RETRIES
> 
> I added this code (rate is struct ieee80211_tx_rate)
> 
> 	if (tx_done->mpdus_failed) {
> 		/* Maybe there is a better way to report this tried vs failed stat up the stack? */
> 		rate->count = tx_done->mpdus_failed + 1;
> 	}
> 	else {
> 		rate->count = 1;
> 	}

Ah, you were asking about mac80211?

I guess if you have the statistic, you can override it in
get_sta_stats() instead of trying to make mac80211 keep them based on
the rate (control) information.

johannes