DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B783520665
Date:   Tue, 23 Oct 2018 18:36:26 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     "Theodore Y. Ts'o" <tytso@mit.edu>
cc:     Larry Finger <Larry.Finger@lwfinger.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: Is Fixes line enough?
In-Reply-To: <20181023143856.GD6850@thunk.org>
Message-ID: <alpine.LRH.2.00.1810231833260.2860@gjva.wvxbf.pm>
References: <a99840d5-7d57-ec1f-1c70-37ffa6cfd31b@lwfinger.net> <20181023143856.GD6850@thunk.org>
User-Agent: Alpine 2.00 (LRH 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Tue, 23 Oct 2018, Theodore Y. Ts'o wrote:

> > A question has come up on the linux-wireless ML. If a patch has a "Fixes"
> > line, is that sufficient to get it flagged as a patch in Stable, or is a
> > "Cc: Stable" line also needed?
> 
> Someone actually asked this question at the Maintainer's Summit,
> actually.  The answer was that the Fixes line is not sufficient for
> Greg's scripts; you have to have the "Cc: stable" line as well.  Greg
> tried using the Fixes line as a trigger, but there were too many cases
> where this pulled in commits that weren't really suitable for the
> Stable kernels.  Sasha's machine-learning lash up will use the Fixes
> line as a signal, but if you want to explicitly request that the patch
> should be cherry-picked into Stable, you should have the "Cc: stable"
> line.

FWIW, I brought this up already at KS 2016, see Jon's coverage here:

	https://lwn.net/Articles/705220/

My primary motivation to bring that up back then was to try to reduce the 
number of patches that are taken into -stable while there is no good 
justification for that (by requiring each and every of those having Fixes: 
present as a requirement), but it didn't really lead anywhere.

-- 
Jiri Kosina
SUSE Labs