DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B62922082D
Message-ID: <c832f9007e0a844d3335a0cd9996818f49df2311.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211: support FTM responder configuration/statistics
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org,
        David Spinadel <david.spinadel@intel.com>
Date:   Thu, 25 Oct 2018 12:44:29 +0200
In-Reply-To: <1538623160-25886-1-git-send-email-pradeepc@codeaurora.org> (sfid-20181004_051935_494006_E9A4C858)
References: <1538623160-25886-1-git-send-email-pradeepc@codeaurora.org>
         (sfid-20181004_051935_494006_E9A4C858)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Pradeep,

On Wed, 2018-10-03 at 20:19 -0700, Pradeep Kumar Chitrapu wrote:
> New bss param ftm_responder is used to notify the driver to
> enable fine timing request (FTM) responder role in AP mode.

I just realized that this is broken in nl80211_channel_switch() and
ieee80211_set_csa_beacon(), doing a CSA will always disable FTM unless
it was actually included in the new configuration.

Doing the trivial thing:

 	memset(&params, 0, sizeof(params));
+	params.beacon_after.ftm_responder = -1;

in nl80211_channel_switch() will not help because then mac80211 will
lose all the extra configuration, and will actually store -1 into its
enabled value which is really strange.

I'd appreciate if you could take a look at this.

Thanks,
johannes