DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E16820856
To:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
From:   Ben Greear <greearb@candelatech.com>
Subject: Bad WARN_ON spam in mac80211 wake_queue
Organization: Candela Technologies
Message-ID: <407303c7-a18e-4c65-529b-b242f3589cf6@candelatech.com>
Date:   Fri, 26 Oct 2018 11:17:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

I made the mistake of configuring 64 ath10k vdevs on an un-modified
4.19-rc5 mac80211, and the (OpenWRT) system mostly killed itself.  I'm not sure
if this is root cause or not, but one of the issues is that this code
hits the WARN_ON in wake_queue() over and over again.  Please make it WARN_ON_ONCE
when you get a chance...my tree is too dirty to make a good patch
in this area.

static void __ieee80211_wake_queue(struct ieee80211_hw *hw, int queue,
                                    enum queue_stop_reason reason,
                                    bool refcounted)
{
         struct ieee80211_local *local = hw_to_local(hw);

         trace_wake_queue(local, queue, reason);

         if (WARN_ON(queue >= hw->queues))
                 return;


Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com