DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C840E2082D
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 29 Oct 2018 11:59:10 -0700
From:   Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org,
        David Spinadel <david.spinadel@intel.com>
Subject: Re: [PATCH] mac80211: support FTM responder configuration/statistics
In-Reply-To: <389c2e4819c83330a3b652f2a45ff024ec94cd2c.camel@sipsolutions.net>
References: <1538623160-25886-1-git-send-email-pradeepc@codeaurora.org>
 (sfid-20181004_051935_494006_E9A4C858)
 <c832f9007e0a844d3335a0cd9996818f49df2311.camel@sipsolutions.net>
 <765cbdd596e96b7cf73239a4e04b06a7@codeaurora.org>
 <389c2e4819c83330a3b652f2a45ff024ec94cd2c.camel@sipsolutions.net>
Message-ID: <03f51a115f6d71923c3212af25c470d3@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

>  	memset(&params, 0, sizeof(params));
> +	params.beacon_csa.ftm_responder = -1;
Hi Johannes,

Agree with the rest, however, I think this may not be needed because 
ftm_responder is already being set to -1,
if NL80211_ATTR_FTM_RESPONDER attribute is not included, in 
nl80211_parse_beacon, which will be called from
nl80211_channel_switch. Please let me know if I may have missed 
something..

         if (attrs[NL80211_ATTR_FTM_RESPONDER]) {

         } else {
                 bcn->ftm_responder = -1;
         }

> 
>  	if (!info->attrs[NL80211_ATTR_WIPHY_FREQ] ||
>  	    !info->attrs[NL80211_ATTR_CH_SWITCH_COUNT])
> 
> 
> If that seems good to you I'll submit the patch.
Sure..Thanks.
> 
> johannes