Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41132C0044C for ; Mon, 29 Oct 2018 20:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F37B820824 for ; Mon, 29 Oct 2018 20:10:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F37B820824 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sipsolutions.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729661AbeJ3FAu (ORCPT ); Tue, 30 Oct 2018 01:00:50 -0400 Received: from s3.sipsolutions.net ([144.76.43.62]:47106 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729520AbeJ3FAu (ORCPT ); Tue, 30 Oct 2018 01:00:50 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1gHDrv-0003J0-TQ; Mon, 29 Oct 2018 21:10:36 +0100 Message-ID: <7f6ec3536d71bf62e64f2592f5e1eabe05256563.camel@sipsolutions.net> Subject: Re: [PATCH 04/19] wilc: add host_interface.c From: Johannes Berg To: Adham.Abozaeid@microchip.com, Ajay.Kathat@microchip.com, linux-wireless@vger.kernel.org Cc: kvalo@codeaurora.org, gregkh@linuxfoundation.org, Ganesh.Krishna@microchip.com, Aditya.Shankar@microchip.com, Venkateswara.Kaja@microchip.com, Claudiu.Beznea@microchip.com Date: Mon, 29 Oct 2018 21:10:14 +0100 In-Reply-To: <5BCA4455.1020307@microchip.com> References: <1537957525-11467-1-git-send-email-ajay.kathat@microchip.com> <1537957525-11467-5-git-send-email-ajay.kathat@microchip.com> (sfid-20180926_122554_993494_C8703D81) <1539009076.3687.64.camel@sipsolutions.net> <5BBE5BCF.5020706@microchip.com> <1539241314.3687.190.camel@sipsolutions.net> <5BC11B3B.20901@microchip.com> <5c6c7a4d3471a2784d0b203beccd4de9c55b211e.camel@sipsolutions.net> <5BC8D148.7050804@microchip.com> <492fb11bbe66cdea676e126a70a1ba9e1af3c97b.camel@sipsolutions.net> <5BCA4455.1020307@microchip.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > > I'd argue for trying it though as it makes the code MUCH simpler. > > I totally agree that it will be simpler to do the work directly from > the cfg context rather than scheduling it. > On a cortex A5 MPU and SPI bus running on 48Mhz, this takes 20ms in > the idle case, and 100 to 300ms in case of data being transferred in > parallel. That does sound pretty slow ... but OTOH, mostly wpa_s etc. would expect this to actually complete before the next step, so if this is slow and wpa_s/hostapd is much faster, it might send you a lot of things to do and so you'd end up being slow anyway? johannes