Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2961AC0044C for ; Mon, 5 Nov 2018 11:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D175320825 for ; Mon, 5 Nov 2018 11:52:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="LS3xRTKr"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="oPuvXxJ7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D175320825 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727337AbeKEVLk (ORCPT ); Mon, 5 Nov 2018 16:11:40 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:39796 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727035AbeKEVLk (ORCPT ); Mon, 5 Nov 2018 16:11:40 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 833276053D; Mon, 5 Nov 2018 11:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1541418738; bh=SPi2NEZ1aCarU7Vmvqeq3w/NhfzIM0NPl1x6LZeapmU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=LS3xRTKrQf4cUX8vmrtgauq+dp8qel41z68drHXa/S5l3keTta9h/va7EX0rHjjKM ouUgJb/N1NmEIl2mV+EUvAsk8frfva2LPZIqXChJFRVnwkW4NUtpcUA0JXR8WSJiyX lhBqiNZA2hVXyEW75Pg/twcoSfIZlk7EdWMPaydo= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2BC2560112; Mon, 5 Nov 2018 11:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1541418738; bh=SPi2NEZ1aCarU7Vmvqeq3w/NhfzIM0NPl1x6LZeapmU=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=oPuvXxJ7/n9T4T1W+hzsZOG7nxeXnGbVZC5Gny5zAeSa4mU5Si2vGuv0H4HjlkYXf p4I+eA86Pak2qRJUIrchvw8i885knAUDxelKX1r8KgFZYQrG8RqFzbyJbUga/QO8gE ck9KI9hG9kokeUaO13pIcslYkTit+jx9RipbzRFQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2BC2560112 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] ath10k: report tx rate using ieee80211_tx_rate_update() From: Kalle Valo In-Reply-To: <1540530438-11292-1-git-send-email-akolli@codeaurora.org> References: <1540530438-11292-1-git-send-email-akolli@codeaurora.org> To: Anilkumar Kolli Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Anilkumar Kolli User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20181105115218.833276053D@smtp.codeaurora.org> Date: Mon, 5 Nov 2018 11:52:18 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Anilkumar Kolli wrote: > Mesh path metric needs tx rate information from ieee80211_tx_status() > call but in ath10k there is no mechanism to report tx rate information > via ieee80211_tx_status(), the tx rate is only accessible via > sta_statiscs() op. > > Per peer tx stats has tx rate info available, Tx rate is available > to ath10k driver after every 4 PPDU sent in the air. For each PPDU, > ath10k driver updates rate informattion to mac80211 using > ieee80211_tx_rate_update(). > > Per peer txrate information is updated through per peer statistics > and is available for QCA9888/QCA9984/QCA4019/QCA998X only > > Tested on QCA9984 with firmware-5.bin_10.4-3.5.3-00053 > Tested on QCA998X with firmware-5.bin_10.2.4-1.0-00036 > > Signed-off-by: Anilkumar Kolli The corresponding mac80211 patch is not yet in ath-next branch, I'll wait for that. drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_update_per_peer_tx_stats': drivers/net/wireless/ath/ath10k/htt_rx.c:3060:3: error: implicit declaration of function 'ieee80211_tx_rate_update'; did you mean 'ieee80211_tx_dequeue'? [-Werror=implicit-function-declaration] ieee80211_tx_rate_update(ar->hw, sta, &arsta->tx_info); ^~~~~~~~~~~~~~~~~~~~~~~~ ieee80211_tx_dequeue cc1: some warnings being treated as errors make[5]: *** [drivers/net/wireless/ath/ath10k/htt_rx.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [drivers/net/wireless/ath/ath10k] Error 2 make[3]: *** [drivers/net/wireless/ath] Error 2 make[2]: *** [drivers/net/wireless] Error 2 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 Patch set to Awaiting Upstream. -- https://patchwork.kernel.org/patch/10656925/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches