DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0630B2085A
Subject: Re: [PATCH 6/6] brcmfmac: Cleanup brcmf_fw_request_done()
To:     Arend van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>
Cc:     linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com
References: <20181009124755.25402-1-hdegoede@redhat.com>
 <20181009124755.25402-6-hdegoede@redhat.com>
 <9741c4fc-fbe2-c45c-9775-18b71dbcfc85@broadcom.com>
From:   Hans de Goede <hdegoede@redhat.com>
Message-ID: <5859a801-2e69-4e6b-f946-2e269a26797e@redhat.com>
Date:   Mon, 5 Nov 2018 15:34:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <9741c4fc-fbe2-c45c-9775-18b71dbcfc85@broadcom.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi,

On 05-11-18 12:42, Arend van Spriel wrote:
> On 10/9/2018 2:47 PM, Hans de Goede wrote:
>> The "cur" variable is now only used for a debug print and we already
>> print the same info from brcmf_fw_complete_request(), so the debug print
>> does not provide any extra info and we can remove it.
> 
> I guess this could have been collapsed in the first patch introducing brcmf_fw_complete_request(). All-in-all a nice cleanup. Thanks.

The idea of doing this in 2 separate patches is to make the first
patch (which is non trivial) easier to review.

Regards,

Hans


> 
> Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> ?.../net/wireless/broadcom/brcm80211/brcmfmac/firmware.c?? | 8 +-------
>> ?1 file changed, 1 insertion(+), 7 deletions(-)
>