DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CFEB920827
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 14A6660271
From:   Kalle Valo <kvalo@codeaurora.org>
To:     =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <zajec5@gmail.com>
Cc:     Rip Route <riproute@gmail.com>,
        Arend Van Spriel <arend.vanspriel@broadcom.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>,
        David Miller <davem@davemloft.net>,
        =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>,
        Chung-Hsien Hsu <stanley.hsu@cypress.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "open list\:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER
        \<brcm80211-dev-list.pdl\@broadcom.com\>\," 
        <brcm80211-dev-list.pdl@broadcom.com>,
        "open list\:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER
        \<brcm80211-dev-list.pdl\@broadcom.com\>\," 
        <brcm80211-dev-list@cypress.com>, Dan HAAB <dan.haab@luxul.com>
Subject: Re: [PATCH] brcmfmac: support STA info struct v7
References: <1539289141-13689-1-git-send-email-dan.haab@luxul.com>
        <CACna6rxJUxGLw1P7d4nCRocHxSs3nyxBvHzr4YaDH9ES+kg39g@mail.gmail.com>
Date:   Wed, 07 Nov 2018 12:02:48 +0200
In-Reply-To: <CACna6rxJUxGLw1P7d4nCRocHxSs3nyxBvHzr4YaDH9ES+kg39g@mail.gmail.com>
        (=?utf-8?Q?=22Rafa=C5=82_Mi=C5=82ecki=22's?= message of "Wed, 7 Nov 2018
 10:46:23 +0100")
Message-ID: <87r2fxciif.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Rafa=C5=82 Mi=C5=82ecki <zajec5@gmail.com> writes:

> On Thu, 11 Oct 2018 at 22:21, Dan Haab <riproute@gmail.com> wrote:
>> The newest firmwares provide STA info using v7 of the struct. As v7
>> isn't backward compatible, a union is needed.
>>
>> Even though brcmfmac does not use any of the new info it's important to
>> provide the proper struct buffer. Without this change new firmwares will
>> fallback to the very limited v3 instead of something in between such as
>> v4.
>>
>> Signed-off-by: Dan Haab <dan.haab@luxul.com>
>
> It's too bad Broadcom's existing struct has been changed instead of
> just being extended.
>
> The patch looks good to me though. I just wanted to share my opinion /
> ping due to patch being marked as "Deferred".
>
> Reviewed-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>

Good that you brought this up, I wasn't sure what to do with it so I
marked as Deferred. Arend, please let me know what I should do.

--=20
Kalle Valo