DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0697E20827
Subject: Re: [PATCH] brcmfmac: support STA info struct v7
To:     Kalle Valo <kvalo@codeaurora.org>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
References: <1539289141-13689-1-git-send-email-dan.haab@luxul.com>
 <CACna6rxJUxGLw1P7d4nCRocHxSs3nyxBvHzr4YaDH9ES+kg39g@mail.gmail.com>
 <87r2fxciif.fsf@codeaurora.org>
Cc:     Rip Route <riproute@gmail.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>,
        David Miller <davem@davemloft.net>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Chung-Hsien Hsu <stanley.hsu@cypress.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
        <brcm80211-dev-list.pdl@broadcom.com>,
        brcm80211-dev-list.pdl@broadcom.com,
        "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
        <brcm80211-dev-list.pdl@broadcom.com>,
        brcm80211-dev-list@cypress.com, Dan HAAB <dan.haab@luxul.com>
From:   Arend van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <9ba1e229-6d9a-b40a-cd4a-ae3a2e768d6c@broadcom.com>
Date:   Wed, 7 Nov 2018 22:00:47 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <87r2fxciif.fsf@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 11/7/2018 11:02 AM, Kalle Valo wrote:
> Rafał Miłecki <zajec5@gmail.com> writes:
>
>> On Thu, 11 Oct 2018 at 22:21, Dan Haab <riproute@gmail.com> wrote:
>>> The newest firmwares provide STA info using v7 of the struct. As v7
>>> isn't backward compatible, a union is needed.
>>>
>>> Even though brcmfmac does not use any of the new info it's important to
>>> provide the proper struct buffer. Without this change new firmwares will
>>> fallback to the very limited v3 instead of something in between such as
>>> v4.
>>>
>>> Signed-off-by: Dan Haab <dan.haab@luxul.com>
>>
>> It's too bad Broadcom's existing struct has been changed instead of
>> just being extended.
>>
>> The patch looks good to me though. I just wanted to share my opinion /
>> ping due to patch being marked as "Deferred".
>>
>> Reviewed-by: Rafał Miłecki <rafal@milecki.pl>
>
> Good that you brought this up, I wasn't sure what to do with it so I
> marked as Deferred. Arend, please let me know what I should do.

Currently there is no issue as there is currently no image in 
linux-firmware relying on v7 structure. However, it is not unlikely that 
people are using firmware from other sources. As said earlier I am fine 
with this change although v7 structure already was extended. I have a 
small remark on the patch, which I will send out later.

Regards,
Arend