DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2C1420818
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 08 Nov 2018 18:12:49 +0530
From:   Tamizh chelvam <tamizhr@codeaurora.org>
To:     Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Cc:     ath10k@lists.infradead.org, johannes@sipsolutions.net,
        linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/4] mac80211: Add api to support configuring TID specific
 configuration
In-Reply-To: <20181106103325.5phrwo2pv2rc26pd@bars>
References: <1540230918-27712-1-git-send-email-tamizhr@codeaurora.org>
 <1540230918-27712-4-git-send-email-tamizhr@codeaurora.org>
 <20181106103325.5phrwo2pv2rc26pd@bars>
Message-ID: <a6161336017a59081c24f86a17fee014@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2018-11-06 16:03, Sergey Matyukevich wrote:
>> Signed-off-by: Tamizh chelvam <tamizhr@codeaurora.org>
>> ---
>>  include/net/mac80211.h    |   40 +++++++++++++++++++++++++
>>  net/mac80211/cfg.c        |   71 
>> +++++++++++++++++++++++++++++++++++++++++++++
>>  net/mac80211/driver-ops.h |   16 ++++++++++
>>  net/mac80211/trace.h      |   34 ++++++++++++++++++++++
>>  4 files changed, 161 insertions(+)
>> 
>> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
>> index b6cc3e33..7fa7e25 100644
>> --- a/include/net/mac80211.h
>> +++ b/include/net/mac80211.h
>> @@ -1478,6 +1478,35 @@ struct ieee80211_channel_switch {
>>         u8 count;
>>  };
>> 
>> +/*
>> + * enum ieee80211_tid_conf_change - TID change configuration 
>> notification flags
>> + *
>> + * These flags are used with the set_tid_conf() callback
>> + * to indicate which TID configuration parameter changed.
>> + *
>> + * @TID_RETRY_CONF_CHANGED: retry configuration changed.
>> + * @TID_AGGR_CONF_CHANGED: Aggregation config changed for the TID.
>> + */
>> +enum ieee80211_tid_conf_change {
>> +       TID_RETRY_CONF_CHANGED          = BIT(0),
>> +       TID_AGGR_CONF_CHANGED           = BIT(1),
>> +};
> 
> Following your approach, AMSDU support can be added in addition to
> AMPDU. So I would suggest to replace AGGR by AMPDU right away.
> 
>> +
>> +/*
>> + * struct ieee80211_tid_conf - holds the tid configiuration data
>> + * The information provided in the structure is required for the 
>> driver
>> + * to configure TID specific configuration.
>> + * @tid: TID number
>> + * @retry_short: retry count value
>> + * @retry_long: retry count value
>> + * @aggr: enable/disable aggregation
>> + */
>> +struct ieee80211_tid_conf {
>> +       u8 tid;
>> +       int retry_short;
>> +       int retry_long;
>> +       bool aggr;
>> +};
> 
> ditto: aggr -> ampdu
> 
Sure. I'll update in the next version.

Thanks,
Tamizh.