DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 875632081C
MIME-Version: 1.0
References: <1541648845-194984-1-git-send-email-chi-hsien.lin@cypress.com> <1541648845-194984-3-git-send-email-chi-hsien.lin@cypress.com>
In-Reply-To: <1541648845-194984-3-git-send-email-chi-hsien.lin@cypress.com>
From:   Franky Lin <franky.lin@broadcom.com>
Date:   Thu, 8 Nov 2018 11:19:15 -0800
Message-ID: <CA+8PC_fZ8u+ii_6vdvuLSqszzFcNzhd6dz-AHGR6tByfAgPgcg@mail.gmail.com>
Subject: Re: [PATCH 2/5] brcmfmac: remove "arp_hostip_clear" from "brcmf_netdev_stop"
To:     Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>
Cc:     "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" 
        <linux-wireless@vger.kernel.org>, brcm80211-dev-list@broadcom.com,
        brcm80211-dev-list <brcm80211-dev-list@cypress.com>,
        Arend Van Spriel <arend.vanspriel@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Wright Feng <Wright.Feng@cypress.com>,
        Kalle Valo <kvalo@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 7, 2018 at 7:48 PM Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com> wrote:
>
> From: Wright Feng <wright.feng@cypress.com>
>
> The firmware does not respond ARP request and causes ping failure with
> following steps:
>
> 1. Bring up interface
>    ifconfig wlan0 up or start wpa_supplicant
> 2. Set the IP address
>    ifconfig wlan0 192.168.100.10
> 3. Bring down interface or
>    ifconfig wlan0 down or kill wpa_supplicant
> 4. Bring up interface again and set the same IP address
> 5. Connect to AP(192.168.100.1) and ping to AP will be failed.
>
> FMAC clears arp_hostip when bringing down the interface, but not set it
> back if setting the same IP address. We are able to see the IP address
> in interface info(inconfig wlan0) but the ping still cannot work because
> the firmware ARP offload does not respond the ARP request.
> Because of that, we remove "arp_hostip_clear" from function
> "brcmf_netdev_stop"

Shouldn't brcmf_inetaddr_changed get called when the interface up again?

Thanks,
- Franky

>
> Signed-off-by: Wright Feng <wright.feng@cypress.com>
> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
> index b1f702faff4f..e1666cf3801c 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
> @@ -533,8 +533,6 @@ static int brcmf_netdev_stop(struct net_device *ndev)
>
>         brcmf_cfg80211_down(ndev);
>
> -       brcmf_fil_iovar_data_set(ifp, "arp_hostip_clear", NULL, 0);
> -
>         brcmf_net_setcarrier(ifp, false);
>
>         return 0;
> --
> 2.1.0
>