DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 207122081C
Message-ID: <0322ee25650343fffdcf3fef19cda9090af117fc.camel@sipsolutions.net>
Subject: Re: [PATCH] nl80211: Add support to notify radar event info
 received from STA
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Sriram R <srirrama@codeaurora.org>
Cc:     linux-wireless@vger.kernel.org
Date:   Fri, 09 Nov 2018 13:04:27 +0100
In-Reply-To: <1539940356-1335-1-git-send-email-srirrama@codeaurora.org>
References: <1539940356-1335-1-git-send-email-srirrama@codeaurora.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On Fri, 2018-10-19 at 14:42 +0530, Sriram R wrote:
[...]

This looks fine, but I think it would be nice to have some extended
netlink error reporting for at least some of these errors:

> +	dfs_region = reg_get_dfs_region(wiphy);
> +	if (dfs_region == NL80211_DFS_UNSET)
> +		return -EINVAL;
> +
> +	err = nl80211_parse_chandef(rdev, info, &chandef);
> +	if (err)
> +		return err;
> +
> +	err = cfg80211_chandef_dfs_required(wiphy, &chandef, wdev->iftype);
> +	if (err < 0)
> +		return err;
> +
> +	if (err == 0)
> +		return -EINVAL;
> +
> +	/* Do not process this notification if radar is already detected
> +	 * by kernel on this channel
> +	 */
> +	if (chandef.chan->dfs_state == NL80211_DFS_UNAVAILABLE)
> +		return -EINVAL;

And maybe that last one should just return 0?

johannes