DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AA3220840
Subject: Re: [PATCH v2] brcmfmac: support STA info struct v7
To:     Dan Haab <riproute@gmail.com>, Kalle Valo <kvalo@codeaurora.org>
References: <1541781535-10523-1-git-send-email-dan.haab@luxul.com>
Cc:     Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
        Wright Feng <wright.feng@cypress.com>,
        "David S. Miller" <davem@davemloft.net>,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
        Chung-Hsien Hsu <stanley.hsu@cypress.com>,
        linux-wireless@vger.kernel.org,
        brcm80211-dev-list.pdl@broadcom.com,
        brcm80211-dev-list@cypress.com, Dan Haab <dan.haab@luxul.com>
From:   Arend van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <24a7c83c-0fdd-5b2c-f9ad-813b4d17ab55@broadcom.com>
Date:   Sat, 10 Nov 2018 21:22:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1541781535-10523-1-git-send-email-dan.haab@luxul.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 11/9/2018 5:38 PM, Dan Haab wrote:
> The newest firmwares provide STA info using v7 of the struct. As v7
> isn't backward compatible, a union is needed.
>
> Even though brcmfmac does not use any of the new info it's important to
> provide the proper struct buffer. Without this change new firmwares will
> fallback to the very limited v3 instead of something in between such as
> v4.

I would expect a changelog, but looking at the patch is addresses my 
comments nicely so....

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Dan Haab <dan.haab@luxul.com>
> Reviewed-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  .../broadcom/brcm80211/brcmfmac/fwil_types.h       | 40 ++++++++++++++++++----
>  1 file changed, 33 insertions(+), 7 deletions(-)