DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10B6120871
Subject: Re: [EXTERNAL] Re: [PATCH] ath10k: Disable 4addr source port learning
 in 10.4 FW by default
From:   Sebastian Gottschall <s.gottschall@newmedia-net.de>
To:     murugana@codeaurora.org, ath10k@lists.infradead.org
Cc:     linux-wireless@vger.kernel.org
References: <20181109061121.4184-1-murugana@codeaurora.org>
 <0d74b002-e36d-8169-34e8-59338eac6918@newmedia-net.de>
 <00fd01d4798e$1c0d2f10$54278d30$@codeaurora.org>
 <18df2020-f8c4-b9f7-cf9c-63802ea02429@newmedia-net.de>
Message-ID: <cc8040a6-47f8-c8f0-0451-2e220d91d62c@newmedia-net.de>
Date:   Mon, 12 Nov 2018 05:10:33 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <18df2020-f8c4-b9f7-cf9c-63802ea02429@newmedia-net.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

i tested my proposal now and it fixes the issue. the submitted patch was 
simply broken at that small point

Am 12.11.2018 um 03:44 schrieb Sebastian Gottschall:
> hint for a possible fix
>
>
> disable_4addr_src_lrn is not set in 10_4 vdev parameter map. so this 
> feature cannot work
>
>
> --- wmi.c       (Revision 4214)
> +++ wmi.c       (Arbeitskopie)
> @@ -972,6 +972,7 @@
>         .meru_vc = WMI_VDEV_PARAM_UNSUPPORTED,
>         .rx_decap_type = WMI_VDEV_PARAM_UNSUPPORTED,
>         .bw_nss_ratemask = WMI_VDEV_PARAM_UNSUPPORTED,
> +       .disable_4addr_src_lrn = WMI_VDEV_PARAM_UNSUPPORTED,
>  };
>
>  static struct wmi_vdev_param_map wmi_10_4_vdev_param_map = {
> @@ -1049,6 +1050,7 @@
>         .bw_nss_ratemask = WMI_10_4_VDEV_PARAM_BW_NSS_RATEMASK,
>         .inc_tsf = WMI_10_4_VDEV_PARAM_TSF_INCREMENT,
>         .dec_tsf = WMI_10_4_VDEV_PARAM_TSF_DECREMENT,
> +       .disable_4addr_src_lrn = 
> WMI_10_4_VDEV_PARAM_DISABLE_4_ADDR_SRC_LRN,
>  };
>
> Am 11.11.2018 um 08:13 schrieb murugana@codeaurora.org:
>> Hi Sebastian,
>>
>>> after tested 2 WDS devices (one WDS AP, one WDS STA) with 9984 (netgear
>>> r7800) i found out that the issue persists. gtk rekeying fails, so 
>>> disconnect and
>>> reconnect after 60 minutes.
>> Are you using the latest FW 10.4-3.6.0.1-00003 for 9984 ( mainly on 
>> the AP side ) ?
>>
>> (https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=a00e61b9203186561dc90de1ff7ed4d5f5e920d5) 
>>
>>
>> Thanks,
>> Sathishkumar
>>
>>
>>