DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07A3D223D8
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 12 Nov 2018 16:29:29 +0530
From:   Sriram R <srirrama@codeaurora.org>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH] nl80211: Add support to notify radar event info received
 from STA
In-Reply-To: <0322ee25650343fffdcf3fef19cda9090af117fc.camel@sipsolutions.net>
References: <1539940356-1335-1-git-send-email-srirrama@codeaurora.org>
 <0322ee25650343fffdcf3fef19cda9090af117fc.camel@sipsolutions.net>
Message-ID: <772255895b9aaf30b2414111d4f8f4fa@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 2018-11-09 17:34, Johannes Berg wrote:
> On Fri, 2018-10-19 at 14:42 +0530, Sriram R wrote:
> [...]
> 
> This looks fine, but I think it would be nice to have some extended
> netlink error reporting for at least some of these errors:
> 
Sure Johannes, I'll add them in the next patch revision.
>> +	dfs_region = reg_get_dfs_region(wiphy);
>> +	if (dfs_region == NL80211_DFS_UNSET)
>> +		return -EINVAL;
>> +
>> +	err = nl80211_parse_chandef(rdev, info, &chandef);
>> +	if (err)
>> +		return err;
>> +
>> +	err = cfg80211_chandef_dfs_required(wiphy, &chandef, wdev->iftype);
>> +	if (err < 0)
>> +		return err;
>> +
>> +	if (err == 0)
>> +		return -EINVAL;
>> +
>> +	/* Do not process this notification if radar is already detected
>> +	 * by kernel on this channel
>> +	 */
>> +	if (chandef.chan->dfs_state == NL80211_DFS_UNAVAILABLE)
>> +		return -EINVAL;
> 
> And maybe that last one should just return 0?
You're right. I'll return success here.
Thanks,
Sriram.R

> 
> johannes