DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABE0A223AE
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 12 Nov 2018 21:56:39 +0530
From:   Balaji Pothunoori <bpothuno@codeaurora.org>
To:     johannes@sipsolutions.net
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5] iw: ack signal support for tx ack packets
In-Reply-To: <1532010590-475-1-git-send-email-bpothuno@codeaurora.org>
References: <1532010590-475-1-git-send-email-bpothuno@codeaurora.org>
Message-ID: <092e18e05296d9e2e7e8580603ac8b1d@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Hi Johannes,

Now that corresponding driver patches are merged, could you please let 
me know if anything is left from our end for merging this patch?

Regards,
Balaji.

On 2018-07-19 19:59, Balaji Pothunoori wrote:
> This patch is to display the average ack signal,
> last ack signal of tx ack packets.
> 
> Signed-off-by: Balaji Pothunoori <bpothuno@codeaurora.org>
> ---
> v5:
>  * Rebased, No changes
> v4:
>  * Changed the subject
>  * Added last ack signal support and renamed avg ack signal macro
> v3:
>  * Added version no
> v2:
>  * Removed nl80211.h changes and modified the commit log
> 
>  station.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/station.c b/station.c
> index 38c5f91..fd38043 100644
> --- a/station.c
> +++ b/station.c
> @@ -308,6 +308,8 @@ static int print_sta_handler(struct nl_msg *msg, 
> void *arg)
>  		[NL80211_STA_INFO_TID_STATS] = { .type = NLA_NESTED },
>  		[NL80211_STA_INFO_BSS_PARAM] = { .type = NLA_NESTED },
>  		[NL80211_STA_INFO_RX_DURATION] = { .type = NLA_U64 },
> +		[NL80211_STA_INFO_ACK_SIGNAL] = {.type = NLA_U8 },
> +		[NL80211_STA_INFO_ACK_SIGNAL_AVG] = { .type = NLA_U8 },
>  	};
>  	char *chain;
> 
> @@ -409,6 +411,14 @@ static int print_sta_handler(struct nl_msg *msg, 
> void *arg)
>  		printf("\n\trx duration:\t%lld us",
>  		       (unsigned long 
> long)nla_get_u64(sinfo[NL80211_STA_INFO_RX_DURATION]));
> 
> +	if (sinfo[NL80211_STA_INFO_ACK_SIGNAL])
> +		printf("\n\tlast ack signal:%d dBm",
> +			(int8_t)nla_get_u8(sinfo[NL80211_STA_INFO_ACK_SIGNAL]));
> +
> +	if (sinfo[NL80211_STA_INFO_ACK_SIGNAL_AVG])
> +		printf("\n\tavg ack signal:\t%d dBm",
> +			(int8_t)nla_get_u8(sinfo[NL80211_STA_INFO_ACK_SIGNAL_AVG]));
> +
>  	if (sinfo[NL80211_STA_INFO_EXPECTED_THROUGHPUT]) {
>  		uint32_t thr;