DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 928CC2243E
Subject: Re: [PATCH] brcmfmac: Use standard SKB list accessors in
 brcmf_sdiod_sglist_rw.
To:     Andy Duan <fugang.duan@nxp.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
References: <20181110.163402.130407398146253939.davem@davemloft.net>
 <VI1PR0402MB36009CD578B9CDBF4449130FFFC30@VI1PR0402MB3600.eurprd04.prod.outlook.com>
 <9667eb4f-36a1-0439-867b-1defc5946bc2@broadcom.com>
 <VI1PR0402MB3600F31F8665EB1BDAFBAE36FFC30@VI1PR0402MB3600.eurprd04.prod.outlook.com>
 <6679c7f3-9df2-1eb0-6f0d-725717460a82@broadcom.com>
Cc:     "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
From:   Arend van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <c9020dd1-0ecb-5d2d-0e9e-2b31c38b2f64@broadcom.com>
Date:   Wed, 14 Nov 2018 12:29:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <6679c7f3-9df2-1eb0-6f0d-725717460a82@broadcom.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

On 11/14/2018 11:57 AM, Arend van Spriel wrote:
> On 11/14/2018 11:54 AM, Andy Duan wrote:
>> From: Arend van Spriel [mailto:arend.vanspriel@broadcom.com] Sent:
>> 2018年11月14日 16:40
>>> To: Andy Duan <fugang.duan@nxp.com>; David Miller
>>> <davem@davemloft.net>; netdev@vger.kernel.org
>>> Cc: linux-wireless@vger.kernel.org
>>> Subject: Re: [PATCH] brcmfmac: Use standard SKB list accessors in
>>> brcmf_sdiod_sglist_rw.
>>>
>>> On 11/14/2018 4:28 AM, Andy Duan wrote:
>>>> From: David Miller <davem@davemloft.net> Sent: 2018年11月11日 8:34
>>>>> [ As I am trying to remove direct SKB list pointer accesses I am
>>>>>   committing this to net-next.  If this causes a lot of grief I
>>>>>   can and will revert, just let me know. ]
>>>
>>> [...]
>>>
>>>>
>>>> I just have bcm4339 in hands, test the patch on i.MX7D sdb board with
>>> bcm4339, it works fine with iperf testing.
>>>>
>>>> Tested-by: Fugang Duan <fugang.duan@nxp.com>
>>>
>>> Thanks, Andy
>>>
>>> Can you do one more check? Please insert brcmfmac with module parameter
>>> debug=2 and let me know if the following log message is seen:
>>>
>>> brcmfmac: brcmf_sdiod_sgtable_alloc: nents=X
>>>
>>> If not seen, the driver does not go through the patched code.
>> My kernel don't enable debug and DEBUG and CONFIG_BRCM_TRACING, I add
>> the debug info in the brcmf_sdiod_sgtable_alloc(), and the log show
>> the driver go through the sg path:
>> Log: brcmf_sdiod_sgtable_alloc: max_segs:128, sg_support:1, nents=35
>
> Thanks, Andy
>
> Works for me ;-)

I should better read the patch email. I tried to apply the patch to 
wireless-testing, but it failed simply because the patch is already in 
place through net-next as Dave mentioned. Anyway, it is good that it has 
been tested to some extent.

Regards,
Arend