DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6E5A2145D
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CABEB60386
From:   Kalle Valo <kvalo@codeaurora.org>
To:     Joe Perches <joe@perches.com>
Cc:     yhchuang@realtek.com, Larry.Finger@lwfinger.net,
        pkshih@realtek.com, tehuang@realtek.com, sgruszka@redhat.com,
        johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [RFC v4 08/13] rtw88: debug files
References: <1539421245-11847-1-git-send-email-yhchuang@realtek.com>
        <1539421245-11847-9-git-send-email-yhchuang@realtek.com>
        <a731948bf875867be4246b72a661ce71833620b8.camel@perches.com>
        <87y3b1vpjk.fsf@codeaurora.org>
        <0a41d14b9a964b6b7825bf5c55c32f35166354cd.camel@perches.com>
        <e85b7fa45cefc0bc3df15785f34792abe33f41c6.camel@perches.com>
Date:   Thu, 15 Nov 2018 16:15:01 +0200
In-Reply-To: <e85b7fa45cefc0bc3df15785f34792abe33f41c6.camel@perches.com> (Joe
        Perches's message of "Sat, 03 Nov 2018 21:45:50 -0700")
Message-ID: <878t1ubf6i.fsf@codeaurora.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Joe Perches <joe@perches.com> writes:

> On Sat, 2018-10-13 at 13:28 -0700, Joe Perches wrote:
>> On Sat, 2018-10-13 at 18:23 +0300, Kalle Valo wrote:
>> > Joe Perches <joe@perches.com> writes:
> []
>> > > It's very unusual to have _all_ the logging under a CONFIG_<FOO>_DEBUG
>> > > config guard flag.
>> > 
>> > For wireless drivers that is actually quite typical.
>> 
>> No, it isn't.
>> 
>> > IIRC at least ath6kl, ath9k and ath10k do that, most likely also others.
>> 
>> No, they don't.  Check again.
>> 
>> > > Typical debugging would dynamic debugging on a per-line instance andl
>> > > this uses a single dev_dbg for all debugging.
>> > 
>> > I don't recall seeing anyone using per-line dynamic debugging with
>> > wireless drivers. The drivers are so complex that enabling one message
>> > at a time doesn't really get you anywhere, that's why we mostly group
>> > messages into similar groups (or levels) to make it easier to enable
>> > certain debug messages.
>> 
>> You should look harder.  
>> 
>> > > This seems unnecessarily complexity for a negative gain.
>> > 
>> > I haven't reviewed the driver yet but from a quick look I don't see this
>> > as a problem.
>>   
>> It is unnecessarily complex.
>> This saves one dereference per call, but is it really worth it?
>
> Kalle, did I miss a reply here?

I didn't bother to waste my time after reading comments like "check
again" and "look harder".

-- 
Kalle Valo